Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19222

EnvInject undefines NODE_NAME environment variable on master

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Critical
    • Resolution: Unresolved
    • Component/s: envinject-plugin
    • Labels:
      None
    • Environment:
      Windows 7, 64 bit
    • Similar Issues:

      Description

      I have quite a lot of jobs which can roam around between master and about 20 Slaves. The initial job updates an SCM view and compiles the software and starts depending jobs like building an installer. The installer job needs to know on which node to run which it is told by using the parameterized trigger plugin and the node label parameter plugin. After upgrading to latest Jenkins 1.527 this mechanism is broken at least for a Windows 7/64 bit master.

      I had similar problems about a year ago, see JENKINS-14109. Maybe this is helpful.

      Downgrading to 1.526 fixes the issue, so there must be a change in core which caused this. The only suspect from the changes I can see is JENKINS-19042

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Alex Earl
            Path:
            src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
            http://jenkins-ci.org/commit/envinject-plugin/63389901c85ba6c1a903e25df5fe3f815e4c1b36
            Log:
            Fix JENKINS-19222

            Make setting the NODE_NAME similar to what core does.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java http://jenkins-ci.org/commit/envinject-plugin/63389901c85ba6c1a903e25df5fe3f815e4c1b36 Log: Fix JENKINS-19222 Make setting the NODE_NAME similar to what core does.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Gregory Boissinot
            Path:
            src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
            http://jenkins-ci.org/commit/envinject-plugin/4260b55f4cf0f89910fd61d0ae3a0cedbfeda3f5
            Log:
            Merge pull request #39 from slide/master

            Fix JENKINS-19222

            Compare: https://github.com/jenkinsci/envinject-plugin/compare/de93818b4007...4260b55f4cf0

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java http://jenkins-ci.org/commit/envinject-plugin/4260b55f4cf0f89910fd61d0ae3a0cedbfeda3f5 Log: Merge pull request #39 from slide/master Fix JENKINS-19222 Compare: https://github.com/jenkinsci/envinject-plugin/compare/de93818b4007...4260b55f4cf0
            Hide
            chritto Christopher McGrath added a comment -

            I tried this again with the merged pull request from Alex Earl and the bug seems to be fixed on my end. In our case, our Perforce SCM configuration uses ${NODE_NAME} to generate workspaces for each machine - but polling was broken on the master.

            Thanks!

            Show
            chritto Christopher McGrath added a comment - I tried this again with the merged pull request from Alex Earl and the bug seems to be fixed on my end. In our case, our Perforce SCM configuration uses ${NODE_NAME} to generate workspaces for each machine - but polling was broken on the master. Thanks!
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Does anybody still see this issue?

            Show
            oleg_nenashev Oleg Nenashev added a comment - Does anybody still see this issue?
            Hide
            pjdarton pjdarton added a comment -

            This sounds like a manifestation of the more generic bug JENKINS-24283 - variables with empty values get unset.  I'd guess that fixing that one would fix this one.

            Show
            pjdarton pjdarton added a comment - This sounds like a manifestation of the more generic bug JENKINS-24283 - variables with empty values get unset.  I'd guess that fixing that one would fix this one.

              People

              • Assignee:
                gbois Gregory Boissinot
                Reporter:
                bruce Dirk Kuypers
              • Votes:
                6 Vote for this issue
                Watchers:
                15 Start watching this issue

                Dates

                • Created:
                  Updated: