Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19413

StaplerRequest.getAncestor does not work for lazy block

    Details

    • Similar Issues:

      Description

      It is a common trick to use StaplerRequest.getAncestor to find the model object being configured in a form so that Java code run on the back end can have some context. This works fine if the configuration block was part of the main page load. But if it was injected in a lazy block, e.g. by adding a repeatable section, the request URI is /$stapler/bound/.../render and there are no ancestors, so getAncestor quietly returns null!

      This is especially insidious because you may iteratively test a feature relying on getAncestor successfully, by reloading .../configure after making code changes; but if you never try adding the section for the first time you might never notice this problem.

      The workaround is to check for a Referer header and manually parse this out to find the model object of interest. But Stapler ought to do this for you automatically.

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is blocking JENKINS-26093 [ JENKINS-26093 ]
            jglick Jesse Glick made changes -
            Labels jelly stapler jelly stapler workflow
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-24165 [ JENKINS-24165 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-20959 [ JENKINS-20959 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-36315 [ JENKINS-36315 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 150862 ] JNJira + In-Review [ 177793 ]
            abayer Andrew Bayer made changes -
            Labels jelly stapler workflow jelly pipeline stapler workflow
            abayer Andrew Bayer made changes -
            Labels jelly pipeline stapler workflow jelly pipeline stapler
            jglick Jesse Glick made changes -
            Remote Link This issue links to "Discussion of @ContextInPath (Web Link)" [ 22353 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: