Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19454

Move DecoratedLauncher from the custom-tools plugin to the Jenkins Core

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Class is being utilized by several "tool installation" plugins. In general, plugin can be used for the any nested launchers.

      Related discussion: https://groups.google.com/forum/#!topic/jenkinsci-dev/2_BKLBR0i8E

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/Launcher.java
          http://jenkins-ci.org/commit/jenkins/a865a52562a7f29ff065e3c86e67013cf606f9d5
          Log:
          [FIXED JENKINS-19454] - Added DecoratedLauncher implementation to the core.
          This launcher Allows subclasses to only implement methods they want to override.
          Originally, this launcher has been implemented in Custom Tools Plugin, but there are many duplicates in other plugins => it would be useful to have it in Jenkins core.

          Resolves https://issues.jenkins-ci.org/browse/JENKINS-19454

          Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Launcher.java http://jenkins-ci.org/commit/jenkins/a865a52562a7f29ff065e3c86e67013cf606f9d5 Log: [FIXED JENKINS-19454] - Added DecoratedLauncher implementation to the core. This launcher Allows subclasses to only implement methods they want to override. Originally, this launcher has been implemented in Custom Tools Plugin, but there are many duplicates in other plugins => it would be useful to have it in Jenkins core. Resolves https://issues.jenkins-ci.org/browse/JENKINS-19454 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/Launcher.java
          http://jenkins-ci.org/commit/jenkins/ef943a3ee69529a9f41353f134043ed3363f12e0
          Log:
          [FIXED JENKINS-20559] - ProcStarter: Check for null before cloning of environment variables list

          Resolves https://issues.jenkins-ci.org/browse/JENKINS-20559
          BTW, I also need to add some tests to "Test Harness" in order to improve coverage of nested operations.
          These test require a fix for https://issues.jenkins-ci.org/browse/JENKINS-19454

          Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Launcher.java http://jenkins-ci.org/commit/jenkins/ef943a3ee69529a9f41353f134043ed3363f12e0 Log: [FIXED JENKINS-20559] - ProcStarter: Check for null before cloning of environment variables list Resolves https://issues.jenkins-ci.org/browse/JENKINS-20559 BTW, I also need to add some tests to "Test Harness" in order to improve coverage of nested operations. These test require a fix for https://issues.jenkins-ci.org/browse/JENKINS-19454 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/Launcher.java
          test/src/test/java/hudson/ProcStarterTest.java
          http://jenkins-ci.org/commit/jenkins/4d4ca20a241aac64d000cc29bc27e7f1c1920f94
          Log:
          Merge pull request #1013 from synopsys-arc-oss/launcher_fixes

          [FIXED JENKINS-20559 and JENKINS-19454] - hudson.Launcher bugfix and additional wrapper

          Compare: https://github.com/jenkinsci/jenkins/compare/4f41d2aa28d6...4d4ca20a241a

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Launcher.java test/src/test/java/hudson/ProcStarterTest.java http://jenkins-ci.org/commit/jenkins/4d4ca20a241aac64d000cc29bc27e7f1c1920f94 Log: Merge pull request #1013 from synopsys-arc-oss/launcher_fixes [FIXED JENKINS-20559 and JENKINS-19454] - hudson.Launcher bugfix and additional wrapper Compare: https://github.com/jenkinsci/jenkins/compare/4f41d2aa28d6...4d4ca20a241a
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3432
          [FIXED JENKINS-19454] - Added DecoratedLauncher implementation to the core. (Revision a865a52562a7f29ff065e3c86e67013cf606f9d5)

          Result = SUCCESS
          o.v.nenashev : a865a52562a7f29ff065e3c86e67013cf606f9d5
          Files :

          • core/src/main/java/hudson/Launcher.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3432 [FIXED JENKINS-19454] - Added DecoratedLauncher implementation to the core. (Revision a865a52562a7f29ff065e3c86e67013cf606f9d5) Result = SUCCESS o.v.nenashev : a865a52562a7f29ff065e3c86e67013cf606f9d5 Files : core/src/main/java/hudson/Launcher.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/Launcher.java
          http://jenkins-ci.org/commit/jenkins/1273668ba3b47fd344405ba4c49ec5a83ea9b508
          Log:
          [FIXED JENKINS-20559] - ProcStarter: Check for null before cloning of environment variables list

          Resolves https://issues.jenkins-ci.org/browse/JENKINS-20559
          BTW, I also need to add some tests to "Test Harness" in order to improve coverage of nested operations.
          These test require a fix for https://issues.jenkins-ci.org/browse/JENKINS-19454

          Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
          (cherry picked from commit ef943a3ee69529a9f41353f134043ed3363f12e0)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Launcher.java http://jenkins-ci.org/commit/jenkins/1273668ba3b47fd344405ba4c49ec5a83ea9b508 Log: [FIXED JENKINS-20559] - ProcStarter: Check for null before cloning of environment variables list Resolves https://issues.jenkins-ci.org/browse/JENKINS-20559 BTW, I also need to add some tests to "Test Harness" in order to improve coverage of nested operations. These test require a fix for https://issues.jenkins-ci.org/browse/JENKINS-19454 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com> (cherry picked from commit ef943a3ee69529a9f41353f134043ed3363f12e0)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/Launcher.java
          http://jenkins-ci.org/commit/jenkins/56f1ee4f81f81086036e1c4be4ea4e4b3b1de484
          Log:
          [FIXED JENKINS-19454] - Added DecoratedLauncher implementation to the core.
          This launcher Allows subclasses to only implement methods they want to override.
          Originally, this launcher has been implemented in Custom Tools Plugin, but there are many duplicates in other plugins => it would be useful to have it in Jenkins core.

          Resolves https://issues.jenkins-ci.org/browse/JENKINS-19454

          Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
          (cherry picked from commit a865a52562a7f29ff065e3c86e67013cf606f9d5)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Launcher.java http://jenkins-ci.org/commit/jenkins/56f1ee4f81f81086036e1c4be4ea4e4b3b1de484 Log: [FIXED JENKINS-19454] - Added DecoratedLauncher implementation to the core. This launcher Allows subclasses to only implement methods they want to override. Originally, this launcher has been implemented in Custom Tools Plugin, but there are many duplicates in other plugins => it would be useful to have it in Jenkins core. Resolves https://issues.jenkins-ci.org/browse/JENKINS-19454 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com> (cherry picked from commit a865a52562a7f29ff065e3c86e67013cf606f9d5)

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: