Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19826

Apply button does not work in IE Compat View

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Environment:
      IE8..10 Compatibility View
      build-timeout-1.11
      Jenkins version: 1.480.3, 1.509.2, 1.509.3
    • Similar Issues:

      Description

      Issue causes error after clicking on "Apply button" in Job's configuration (in IE with CompatView). Browser opens an empty new page, previous page shows an empty error box. BTW, "save" button works well..

      Examples of erroneous requests:

      • "/job/MY_JOB/descriptorByName/hudson.plugins.build_timeout.BuildTimeoutWrapper/fillTimeoutPercentageItems"
      • "/job/MY_JOB_2/descriptorByName/com.cloudbees.jenkins.plugins.sshagent.SSHAgentBuildWrapper/fillUserItems"
      • ...

      Exception message: Invalid argument

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/resources/lib/form/apply/apply.js
            http://jenkins-ci.org/commit/jenkins/dda099c19a7a015d9c2fc655754dbb07b1b39455
            Log:
            [FIXED JENKINS-19826] element.setAttribute('name', …) does not work in IE in compatibility mode, so use prototype’s Element(…) which does.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/resources/lib/form/apply/apply.js http://jenkins-ci.org/commit/jenkins/dda099c19a7a015d9c2fc655754dbb07b1b39455 Log: [FIXED JENKINS-19826] element.setAttribute('name', …) does not work in IE in compatibility mode, so use prototype’s Element(…) which does.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Thanks a lot for the fix

            Show
            oleg_nenashev Oleg Nenashev added a comment - Thanks a lot for the fix
            Hide
            jglick Jesse Glick added a comment -

            @oleg_nenashev sure; please help verify in any way you can.

            Show
            jglick Jesse Glick added a comment - @oleg_nenashev sure; please help verify in any way you can.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3153
            [FIXED JENKINS-19826] element.setAttribute('name', …) does not work in IE in compatibility mode, so use prototype’s Element(…) which does. (Revision dda099c19a7a015d9c2fc655754dbb07b1b39455)

            Result = SUCCESS
            Jesse Glick : dda099c19a7a015d9c2fc655754dbb07b1b39455
            Files :

            • core/src/main/resources/lib/form/apply/apply.js
            • changelog.html
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3153 [FIXED JENKINS-19826] element.setAttribute('name', …) does not work in IE in compatibility mode, so use prototype’s Element(…) which does. (Revision dda099c19a7a015d9c2fc655754dbb07b1b39455) Result = SUCCESS Jesse Glick : dda099c19a7a015d9c2fc655754dbb07b1b39455 Files : core/src/main/resources/lib/form/apply/apply.js changelog.html
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/resources/lib/form/apply/apply.js
            http://jenkins-ci.org/commit/jenkins/eca76d7700231a83db3db98d43e570670f48fc23
            Log:
            [FIXED JENKINS-19826] element.setAttribute('name', …) does not work in IE in compatibility mode, so use prototype’s Element(…) which does.

            (cherry picked from commit dda099c19a7a015d9c2fc655754dbb07b1b39455)

            Conflicts:
            changelog.html

            Compare: https://github.com/jenkinsci/jenkins/compare/14214d9b2785...eca76d770023

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/lib/form/apply/apply.js http://jenkins-ci.org/commit/jenkins/eca76d7700231a83db3db98d43e570670f48fc23 Log: [FIXED JENKINS-19826] element.setAttribute('name', …) does not work in IE in compatibility mode, so use prototype’s Element(…) which does. (cherry picked from commit dda099c19a7a015d9c2fc655754dbb07b1b39455) Conflicts: changelog.html Compare: https://github.com/jenkinsci/jenkins/compare/14214d9b2785...eca76d770023

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: