Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19995

git2: http+userpwd appear in clear text in the inline validation in job configuration screen

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: git-plugin
    • Labels:
      None
    • Environment:
      git-client 1.4.0
      git-plugin 2.0-beta-3
    • Similar Issues:

      Description

      The result can be seen in the attached screenshot

        Attachments

          Activity

          Hide
          vlatombe Vincent Latombe added a comment -

          user/pwd is also displayed in case the repo is invalid (which is itself another issue because it triggers an http 500, i've attached the corresponding stacktrace)

          Show
          vlatombe Vincent Latombe added a comment - user/pwd is also displayed in case the repo is invalid (which is itself another issue because it triggers an http 500, i've attached the corresponding stacktrace)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
          http://jenkins-ci.org/commit/git-client-plugin/c1fb1cae6d28994108354526c82bd6b5bce81d6b
          Log:
          [FIXED JENKINS-19995] hide credentials in log/exception messages

          Compare: https://github.com/jenkinsci/git-client-plugin/compare/5967f1e8c1bc...c1fb1cae6d28

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java http://jenkins-ci.org/commit/git-client-plugin/c1fb1cae6d28994108354526c82bd6b5bce81d6b Log: [FIXED JENKINS-19995] hide credentials in log/exception messages Compare: https://github.com/jenkinsci/git-client-plugin/compare/5967f1e8c1bc...c1fb1cae6d28

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              vlatombe Vincent Latombe
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: