Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20148

Misleading description of the 'workspace' permission

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      The tooltip on the Job/Workspace permission in the authorization configuration matrix after saying what the permission really does suggests that "if you don't want an user to access the source code, you can do so by revoking this permission".

      Unfortunately the workspace is often only one of many ways to access the source code via Jenkins, which makes the suggestion rather misleading. Eg. for maven projects the archived source artifacts or the source xref report in the archived maven-generated site, both of which are accessible without the 'workspace' permission, give access to the sources.

        Attachments

          Issue Links

            Activity

            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3885
            [FIXED JENKINS-20148] Rephrase Workspace permission description (Revision 801f37d5a11554fb97bf9c8edbd9f3e5bd21a47f)

            Result = SUCCESS
            daniel-beck : 801f37d5a11554fb97bf9c8edbd9f3e5bd21a47f
            Files :

            • core/src/main/resources/hudson/model/Messages.properties
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3885 [FIXED JENKINS-20148] Rephrase Workspace permission description (Revision 801f37d5a11554fb97bf9c8edbd9f3e5bd21a47f) Result = SUCCESS daniel-beck : 801f37d5a11554fb97bf9c8edbd9f3e5bd21a47f Files : core/src/main/resources/hudson/model/Messages.properties
            Hide
            drulli Ulli Hafner added a comment - - edited

            Does this mean, that plugins should show the contents of workspace files, even if someone has not the permission WORKSPACE (relates to JENKINS-2773)?

            Show
            drulli Ulli Hafner added a comment - - edited Does this mean, that plugins should show the contents of workspace files, even if someone has not the permission WORKSPACE (relates to JENKINS-2773 )?
            Hide
            danielbeck Daniel Beck added a comment -

            Ulli Hafner Plugin functionality not directly equivalent to Workspace permission (e.g. a workspace browser in in Blue Ocean) can probably be considered independent, and may have its own controls.

            Show
            danielbeck Daniel Beck added a comment - Ulli Hafner Plugin functionality not directly equivalent to Workspace permission (e.g. a workspace browser in in Blue Ocean) can probably be considered independent, and may have its own controls.
            Hide
            drulli Ulli Hafner added a comment -

            But shouldn't this be something that Jenkins defines? Is it allowed to view the source code of a workspace file without special permissions? This is something one should define per Jenkins instance and not per plugin.

            Currently my plugins do not show the contents of workspace files (if the WORKSPACE permission is not set), however several other similar plugins do not have this restriction. So what is the suggested behaviour?

            Show
            drulli Ulli Hafner added a comment - But shouldn't this be something that Jenkins defines? Is it allowed to view the source code of a workspace file without special permissions? This is something one should define per Jenkins instance and not per plugin. Currently my plugins do not show the contents of workspace files (if the WORKSPACE permission is not set), however several other similar plugins do not have this restriction. So what is the suggested behaviour?
            Hide
            danielbeck Daniel Beck added a comment -

            Ulli Hafner Not well defined AFAIUI. Notably, plugin functionality is typically optional and needs to be set up in a job first (with someone making the decision to make data from the job available to others), while workspace access would always be available regardless of job configuration. So I don't see this as critical.

            Piggybacking on existing permissions, granting access to everyone with Job/Read, or introducing a new permission are all possible approaches.

            This should be continued in a dev list discussion, I think.

            Show
            danielbeck Daniel Beck added a comment - Ulli Hafner Not well defined AFAIUI. Notably, plugin functionality is typically optional and needs to be set up in a job first (with someone making the decision to make data from the job available to others), while workspace access would always be available regardless of job configuration. So I don't see this as critical. Piggybacking on existing permissions, granting access to everyone with Job/Read, or introducing a new permission are all possible approaches. This should be continued in a dev list discussion, I think.

              People

              • Assignee:
                danielbeck Daniel Beck
                Reporter:
                mdp mdp
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: