Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20170

Email-ext: in-line help missing for triggers

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: email-ext-plugin
    • Labels:
      None
    • Environment:
      Firefox 24.0
      Jenkins 1.509.4
      Email-ext 2.35.1
    • Similar Issues:

      Description

      Steps to reproduce:

      1. Click question mark symbol for Triggers.
      2. Add a trigger.
      3. Click question mark symbol for the added trigger.

      Expected outcome:
      Both in-line help boxes contain text "ERROR: Failed to load help file: Not Found"

        Attachments

          Activity

          Hide
          slide_o_mix Alex Earl added a comment -

          Yup, have a fix for the next release.

          Show
          slide_o_mix Alex Earl added a comment - Yup, have a fix for the next release.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/AbortedTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/AlwaysTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/BuildingTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/FailureTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/FirstFailureTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/FixedTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/FixedUnhealthyTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/NotBuiltTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/RegressionTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/ScriptTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/SecondFailureTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/SuccessTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/UnstableTrigger.java
          src/main/resources/hudson/plugins/emailext/plugins/EmailTrigger/config.groovy
          src/main/resources/hudson/plugins/emailext/plugins/trigger/AbortedTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/AbortedTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/AlwaysTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/BuildingTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/FailureTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/FailureTrigger/help_ja.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/FailureTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/FirstFailureTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/FixedTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/FixedTrigger/help_ja.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/FixedTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/FixedUnhealthyTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/Messages.properties
          src/main/resources/hudson/plugins/emailext/plugins/trigger/Messages_ja.properties
          src/main/resources/hudson/plugins/emailext/plugins/trigger/Messages_zh_TW.properties
          src/main/resources/hudson/plugins/emailext/plugins/trigger/NotBuiltTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/NotBuiltTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger/help_ja.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/RegressionTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/RegressionTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/ScriptTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/ScriptTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/SecondFailureTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger/help_ja.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger/help_ja.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/SuccessTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/SuccessTrigger/help_ja.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/SuccessTrigger/help_zh_TW.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/UnstableTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/UnstableTrigger/help_ja.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/UnstableTrigger/help_zh_TW.html
          src/main/webapp/help/projectConfig/mailType/sendTo.html
          http://jenkins-ci.org/commit/email-ext-plugin/d288c1e40ec86bc2d03a601e15e6e142868ab4a8
          Log:
          Fix JENKINS-20170

          Added help.html files for all the triggers and cleaned up trigger
          descriptors.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java src/main/java/hudson/plugins/emailext/plugins/trigger/AbortedTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/AlwaysTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/BuildingTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/FailureTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/FirstFailureTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/FixedTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/FixedUnhealthyTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/NotBuiltTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/RegressionTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/ScriptTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/SecondFailureTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/SuccessTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/UnstableTrigger.java src/main/resources/hudson/plugins/emailext/plugins/EmailTrigger/config.groovy src/main/resources/hudson/plugins/emailext/plugins/trigger/AbortedTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/AbortedTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/AlwaysTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/BuildingTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/FailureTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/FailureTrigger/help_ja.html src/main/resources/hudson/plugins/emailext/plugins/trigger/FailureTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/FirstFailureTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/FixedTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/FixedTrigger/help_ja.html src/main/resources/hudson/plugins/emailext/plugins/trigger/FixedTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/FixedUnhealthyTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/Messages.properties src/main/resources/hudson/plugins/emailext/plugins/trigger/Messages_ja.properties src/main/resources/hudson/plugins/emailext/plugins/trigger/Messages_zh_TW.properties src/main/resources/hudson/plugins/emailext/plugins/trigger/NotBuiltTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/NotBuiltTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger/help_ja.html src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/RegressionTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/RegressionTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/ScriptTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/ScriptTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/SecondFailureTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger/help_ja.html src/main/resources/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger/help_ja.html src/main/resources/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/SuccessTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/SuccessTrigger/help_ja.html src/main/resources/hudson/plugins/emailext/plugins/trigger/SuccessTrigger/help_zh_TW.html src/main/resources/hudson/plugins/emailext/plugins/trigger/UnstableTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/UnstableTrigger/help_ja.html src/main/resources/hudson/plugins/emailext/plugins/trigger/UnstableTrigger/help_zh_TW.html src/main/webapp/help/projectConfig/mailType/sendTo.html http://jenkins-ci.org/commit/email-ext-plugin/d288c1e40ec86bc2d03a601e15e6e142868ab4a8 Log: Fix JENKINS-20170 Added help.html files for all the triggers and cleaned up trigger descriptors.
          Hide
          slide_o_mix Alex Earl added a comment -

          Added help.html files for all triggers, also added correct help for the sendTo field.

          Show
          slide_o_mix Alex Earl added a comment - Added help.html files for all triggers, also added correct help for the sendTo field.
          Hide
          salsa Sami Salonen added a comment -

          Thanks for the fix. Now all individual triggers have a help text. Unfortunately, the top-level / overall help for all triggers ("Triggers" in GUI) still produces the same error. See step 1 in the description on how to re-produce. Tested with Email-ext 2.36.

          Show
          salsa Sami Salonen added a comment - Thanks for the fix. Now all individual triggers have a help text. Unfortunately, the top-level / overall help for all triggers ("Triggers" in GUI) still produces the same error. See step 1 in the description on how to re-produce. Tested with Email-ext 2.36.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: slide
          Path:
          src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/config.groovy
          http://jenkins-ci.org/commit/email-ext-plugin/f4f1428198a1c50c3e14b8ea96aa498d7a6e0f5b
          Log:
          Fix JENKINS-20170

          Added the correct path for the Triggers entry

          Compare: https://github.com/jenkinsci/email-ext-plugin/compare/76a45d63f662...f4f1428198a1

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: slide Path: src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/config.groovy http://jenkins-ci.org/commit/email-ext-plugin/f4f1428198a1c50c3e14b8ea96aa498d7a6e0f5b Log: Fix JENKINS-20170 Added the correct path for the Triggers entry Compare: https://github.com/jenkinsci/email-ext-plugin/compare/76a45d63f662...f4f1428198a1

            People

            • Assignee:
              slide_o_mix Alex Earl
              Reporter:
              salsa Sami Salonen
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: