Details

    • Similar Issues:

      Description

      Looking at a thread dump from a user with a lot of executors I see lots of:

      Ping thread for channel hudson.remoting.Channel@...:... id=... (0x...) state=TIMED_WAITING
          at java.lang.Thread.sleep(Native Method)
          at hudson.remoting.PingThread.run(PingThread.java:86)
      

      Surely these could all be replaced with a single Timer or ScheduledExecutorService?

        Attachments

          Activity

          Hide
          marcomiller Marco Miller added a comment -

          Could such many pingers negatively impact channel /socket functionality in prod, Jesse?

          Show
          marcomiller Marco Miller added a comment - Could such many pingers negatively impact channel /socket functionality in prod, Jesse?
          Hide
          jglick Jesse Glick added a comment -

          Not sure, but having a lot of extra threads is potentially bad for scalability.

          Show
          jglick Jesse Glick added a comment - Not sure, but having a lot of extra threads is potentially bad for scalability.
          Hide
          jglick Jesse Glick added a comment -

          -Dhudson.slaves.ChannelPinger.pingInterval=0 seems to be the workaround.

          Show
          jglick Jesse Glick added a comment - -Dhudson.slaves.ChannelPinger.pingInterval=0 seems to be the workaround.

            People

            • Assignee:
              Unassigned
              Reporter:
              jglick Jesse Glick
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: