Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20272

Disconnected nodes don't need to be checked for reponse time

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      From the Jenkins log of a non-productive instance I set up to test something:

      Okt 25, 2013 11:26:43 AM hudson.WebAppMain$3 run
      INFO: Jenkins is fully up and running
      Okt 25, 2013 3:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 4:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 5:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 6:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 7:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 8:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      

      The node in question is a dumb slave configured to connect via JNLP. It never was connected.

      There should be no warnings about responsiveness for nodes that aren't connected.

        Attachments

          Activity

          Hide
          olivergondza Oliver Gondža added a comment -

          I suspect the fix is insufficient. The test attached there was passing before the fix, I still see machine disconnected in an improved test[1] and most important of all, I see provisioned computers in openstack-cloud plugin turned offline before launcher kicks in.

          Hence I am reopening and self-assigning this.

          [1] https://github.com/olivergondza/jenkins/commit/a19980b577129d707106b6650305dd49aac5ca8a

          Show
          olivergondza Oliver Gondža added a comment - I suspect the fix is insufficient. The test attached there was passing before the fix, I still see machine disconnected in an improved test [1] and most important of all, I see provisioned computers in openstack-cloud plugin turned offline before launcher kicks in. Hence I am reopening and self-assigning this. [1] https://github.com/olivergondza/jenkins/commit/a19980b577129d707106b6650305dd49aac5ca8a
          Hide
          olivergondza Oliver Gondža added a comment -
          Show
          olivergondza Oliver Gondža added a comment - Fix proposed: https://github.com/jenkinsci/jenkins/pull/3453
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/node_monitors/AbstractAsyncNodeMonitorDescriptor.java
          core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java
          test/src/test/java/hudson/node_monitors/ResponseTimeMonitorTest.java
          http://jenkins-ci.org/commit/jenkins/8872b44cc8823c2106dfc5ba9a344fd1d82e4823
          Log:
          JENKINS-20272 - Disconnected nodes should not be disconnected repeatedly (#3453)

          • [FIX JENKINS-20272] Do not disconnect skipped computers

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/node_monitors/AbstractAsyncNodeMonitorDescriptor.java core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java test/src/test/java/hudson/node_monitors/ResponseTimeMonitorTest.java http://jenkins-ci.org/commit/jenkins/8872b44cc8823c2106dfc5ba9a344fd1d82e4823 Log: JENKINS-20272 - Disconnected nodes should not be disconnected repeatedly (#3453) JENKINS-20272 Reproduce in test [FIX JENKINS-20272] Do not disconnect skipped computers JENKINS-20272 Clean the API a bit * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Extra fix has been applied in 2.126

          Show
          oleg_nenashev Oleg Nenashev added a comment - Extra fix has been applied in 2.126
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/node_monitors/AbstractAsyncNodeMonitorDescriptor.java
          core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java
          test/src/test/java/hudson/node_monitors/ResponseTimeMonitorTest.java
          http://jenkins-ci.org/commit/jenkins/527141e5e8dafe09e4d1c68f10f582243c53c456
          Log:
          JENKINS-20272 - Disconnected nodes should not be disconnected repeatedly (#3453)

          • [FIX JENKINS-20272] Do not disconnect skipped computers

          (cherry picked from commit 8872b44cc8823c2106dfc5ba9a344fd1d82e4823)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/node_monitors/AbstractAsyncNodeMonitorDescriptor.java core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java test/src/test/java/hudson/node_monitors/ResponseTimeMonitorTest.java http://jenkins-ci.org/commit/jenkins/527141e5e8dafe09e4d1c68f10f582243c53c456 Log: JENKINS-20272 - Disconnected nodes should not be disconnected repeatedly (#3453) JENKINS-20272 Reproduce in test [FIX JENKINS-20272] Do not disconnect skipped computers JENKINS-20272 Clean the API a bit (cherry picked from commit 8872b44cc8823c2106dfc5ba9a344fd1d82e4823)

            People

            • Assignee:
              olivergondza Oliver Gondža
              Reporter:
              danielbeck Daniel Beck
            • Votes:
              7 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: