Details

    • Similar Issues:

      Description

      Current versions of email-ext come with 18 triggers. Unfortunately, it seems to be that the UI for managing triggers hasn't kept up with the number of new triggers added.

      The triggers are not grouped, and sorted alphabetically, so that related triggers are far apart, and relationships aren't evident. While trigger names appear to be succinct, the large number means it's more difficult to find specific triggers, and it's not clear what their behavior is without reading the help.

      Some have names that suggest a different behavior from what they do ('Building' looks at first more like 'Before Build' – just later – rather than e.g. 'No longer failing').

      Some seem to have no purpose at all (when can 'Not Built' be triggered? Something related to polling maybe? Or canceled queue items? Help doesn't say)

      Some descriptions seem to be incomplete (Improvement and Regression refer to the number of failures, but seem unrelated to Failure trigger – "test/analysis failures", if it's about that, would be much more helpful)

      Some hide important parts of their config behind 'Advanced' (the script triggers)

      What's the use case for 'Fixed' when there's 'Fixed Unhealthy'?


      A few suggestions:

      • Rename 'Building' to e.g. 'No longer failing'.
      • Try to change the order of triggers in the list, so that related or similar triggers are next to each other
        Maybe keep the alphabetical sort, but name the triggers for the basic state they apply to? "Failure (any)", "Failure (first)", "Failure (second)", "Failure (still failing)" or something like that? "Script: After build", "Script: before Build"; "Still Unstable: More test failures", "Still Unstable: Fewer test failures", ...
      • More exhaustive help: What are 'multiple failures'? When can 'Not Built' be triggered?
      • Show the script text area for script triggers outside 'Advanced', at least when first adding them (since triggers are hidden behind one 'Advanced' button anyway, could always show this without cluttering up general job config screen).

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/java/hudson/plugins/emailext/AttachmentUtils.java
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherContext.java
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
          src/main/java/hudson/plugins/emailext/plugins/ContentBuilder.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/RegressionTrigger.java
          src/main/resources/hudson/plugins/emailext/plugins/trigger/AbortedTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/AlwaysTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/RegressionTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/ScriptTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger/help.html
          src/main/resources/hudson/plugins/emailext/plugins/trigger/UnstableTrigger/help.html
          src/test/java/hudson/plugins/emailext/plugins/ContentBuilderTest.java
          http://jenkins-ci.org/commit/email-ext-plugin/7980566ba93d24b4efd8dcbaddfb52bb5e9a83b5
          Log:
          Fix JENKINS-20384

          Added more information to the help files.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/AttachmentUtils.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherContext.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java src/main/java/hudson/plugins/emailext/plugins/ContentBuilder.java src/main/java/hudson/plugins/emailext/plugins/trigger/RegressionTrigger.java src/main/resources/hudson/plugins/emailext/plugins/trigger/AbortedTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/AlwaysTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/PreBuildTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/RegressionTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/ScriptTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger/help.html src/main/resources/hudson/plugins/emailext/plugins/trigger/UnstableTrigger/help.html src/test/java/hudson/plugins/emailext/plugins/ContentBuilderTest.java http://jenkins-ci.org/commit/email-ext-plugin/7980566ba93d24b4efd8dcbaddfb52bb5e9a83b5 Log: Fix JENKINS-20384 Added more information to the help files.
          Hide
          slide_o_mix Alex Earl added a comment -

          Completed all the items I agreed with (which is the majority).

          Show
          slide_o_mix Alex Earl added a comment - Completed all the items I agreed with (which is the majority).
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/resources/hudson/plugins/emailext/plugins/trigger/NotBuiltTrigger/help.html
          http://jenkins-ci.org/commit/email-ext-plugin/c571196c1d8f623295a295e30a25a8f41c72f810
          Log:
          Update help inline with JENKINS-20384

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/resources/hudson/plugins/emailext/plugins/trigger/NotBuiltTrigger/help.html http://jenkins-ci.org/commit/email-ext-plugin/c571196c1d8f623295a295e30a25a8f41c72f810 Log: Update help inline with JENKINS-20384
          Hide
          slide_o_mix Alex Earl added a comment - - edited

          I am planning on these changes:

          In general changed names of triggers as the following:

          Aborted
          Always
          Before Build
          Failure -> Unstable (Test Failures)
          Failure - Any
          Failure - First
          Failure - Second
          Failure - Still
          Fixed
          Not Built
          Script - After Build
          Script - Before Build
          Status Changed
          Success
          Test Improvement
          Test Regression
          Unstable (Test Failures) - First
          Unstable (Test Failures) - Still
          Unstable (Test Failures)
          Unstable (Test Failures)/Failure -> Success

          I still need to add info to the help for each trigger (I did add information to the "Not Built" help file already). Some of them have been around longer than I have maintained the plugin, and I have never used them in my own CI so I am not sure what they are all for. I'll research and improve the help.

          Moved the script area for script triggers outside of advanced.

          Show
          slide_o_mix Alex Earl added a comment - - edited I am planning on these changes: In general changed names of triggers as the following: Aborted Always Before Build Failure -> Unstable (Test Failures) Failure - Any Failure - First Failure - Second Failure - Still Fixed Not Built Script - After Build Script - Before Build Status Changed Success Test Improvement Test Regression Unstable (Test Failures) - First Unstable (Test Failures) - Still Unstable (Test Failures) Unstable (Test Failures)/Failure -> Success I still need to add info to the help for each trigger (I did add information to the "Not Built" help file already). Some of them have been around longer than I have maintained the plugin, and I have never used them in my own CI so I am not sure what they are all for. I'll research and improve the help. Moved the script area for script triggers outside of advanced.

            People

            • Assignee:
              slide_o_mix Alex Earl
              Reporter:
              danielbeck Daniel Beck
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: