Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20516

Do not warn anymore if there is no description available

    Details

    • Similar Issues:

      Description

      The message "No description available. Please upgrade checkstyle versionuplications in different files shown only in one file" appears when hovering over an identified line.
      i'm using coffeelint to create a checkstyle.xml.

        Attachments

          Activity

          Hide
          aik099 Alexander Obuhovich added a comment -

          Here is the file.

          Right now it appears, that http://pear.php.net/package/PHP_CodeSniffer/ doesn't add anything as a description.

          However maybe adding actual Sniff name used (the PHP class name that did the check) as a description might be used.

          This however needs to be implemented on PHP_CodeSniffer side.

          Show
          aik099 Alexander Obuhovich added a comment - Here is the file. Right now it appears, that http://pear.php.net/package/PHP_CodeSniffer/ doesn't add anything as a description. However maybe adding actual Sniff name used (the PHP class name that did the check) as a description might be used. This however needs to be implemented on PHP_CodeSniffer side.
          Hide
          lyda Kevin Lyda added a comment -

          I filed an issue with the PHP_CodeSniffer project.

          Show
          lyda Kevin Lyda added a comment - I filed an issue with the PHP_CodeSniffer project.
          Hide
          aik099 Alexander Obuhovich added a comment -

          Can anyone attach checkstyle.xml file for which Jenkins will properly display description for each error?

          I'm starting to think that Checkstyle plugin has hardcoded descriptions for Java messages and they're not provided in checkstyle.xml file at all.

          Show
          aik099 Alexander Obuhovich added a comment - Can anyone attach checkstyle.xml file for which Jenkins will properly display description for each error? I'm starting to think that Checkstyle plugin has hardcoded descriptions for Java messages and they're not provided in checkstyle.xml file at all.
          Hide
          drulli Ulli Hafner added a comment -

          Yes this is true: I'm using the descriptions of the checkstyle project! For each warning, I use the warning type as a key to extract the description from the checkstyle jar. So if the warning is not from checkstyle, no description is shown. (Actually the error message in the issue title was intended as a reminder, that I need to update the descriptions to the latest checkstyle version. Since there are so many other tools now reporting in the checkstyle format I should remove the warnings.)

          Show
          drulli Ulli Hafner added a comment - Yes this is true: I'm using the descriptions of the checkstyle project! For each warning, I use the warning type as a key to extract the description from the checkstyle jar. So if the warning is not from checkstyle, no description is shown. (Actually the error message in the issue title was intended as a reminder, that I need to update the descriptions to the latest checkstyle version. Since there are so many other tools now reporting in the checkstyle format I should remove the warnings.)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/checkstyle/rules/CheckStyleRules.java
          src/main/java/hudson/plugins/checkstyle/rules/Rule.java
          src/test/java/hudson/plugins/checkstyle/rules/CheckStyleRulesTest.java
          http://jenkins-ci.org/commit/checkstyle-plugin/fb3dfc8992a47cf828ea6ac2e0eaf232c32ed451
          Log:
          [FIXED JENKINS-20516] Do show warning if rule description is not found.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/checkstyle/rules/CheckStyleRules.java src/main/java/hudson/plugins/checkstyle/rules/Rule.java src/test/java/hudson/plugins/checkstyle/rules/CheckStyleRulesTest.java http://jenkins-ci.org/commit/checkstyle-plugin/fb3dfc8992a47cf828ea6ac2e0eaf232c32ed451 Log: [FIXED JENKINS-20516] Do show warning if rule description is not found.

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              dereremit Sebastian Paul
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: