Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20522

Should use DescriptorVisibilityFilter from JobTypeFilter

    Details

    • Similar Issues:

      Description

      JobTypeFilter.DescriptorImpl.getJobTypes should apply DescriptorVisibilityFilter (passing some context which should ideally be the View that we are working on—try @AncestorInPath) to Items.all() before returning them.

      (Would have filed a pull request if you were on GitHub.)

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            Hide
            jglick Jesse Glick added a comment -

            Filed a PR for this.

            Show
            jglick Jesse Glick added a comment - Filed a PR for this.
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Remote Link This issue links to "PR 6 (Web Link)" [ 11921 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            jglick Jesse Glick added a comment -

            BTW please consider moving off of Subversion and using GitHub.

            And note that there are changes in the master branch of the Git repo which you might not have picked up.

            Show
            jglick Jesse Glick added a comment - BTW please consider moving off of Subversion and using GitHub. And note that there are changes in the master branch of the Git repo which you might not have picked up.
            Show
            jacob_robertson Jacob Robertson added a comment - It's in git? https://github.com/jenkinsci/view-job-filters-plugin
            Hide
            jglick Jesse Glick added a comment -

            Yes, https://github.com/jenkinsci/view-job-filters-plugin/pull/6 as in the link I added to this issue.

            Show
            jglick Jesse Glick added a comment - Yes, https://github.com/jenkinsci/view-job-filters-plugin/pull/6 as in the link I added to this issue.
            Hide
            jglick Jesse Glick added a comment -

            It is going on a year now with no movement. Do you intend to maintain this plugin? Should I consider it abandoned and cut a fresh release myself?

            Show
            jglick Jesse Glick added a comment - It is going on a year now with no movement. Do you intend to maintain this plugin? Should I consider it abandoned and cut a fresh release myself?
            Hide
            jacob_robertson Jacob Robertson added a comment -

            Yes please take over from here.

            Show
            jacob_robertson Jacob Robertson added a comment - Yes please take over from here.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/hudson/views/JobTypeFilter.java
            src/main/java/hudson/views/MavenExtraStepsValuesHelper.java
            src/main/resources/hudson/views/JobTypeFilter/config.jelly
            http://jenkins-ci.org/commit/view-job-filters-plugin/fb754c204acebc22c08111e5c4aa38f53e7d858a
            Log:
            [FIXED JENKINS-20522] Proper usage of TopLevelItemDescriptor.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/hudson/views/JobTypeFilter.java src/main/java/hudson/views/MavenExtraStepsValuesHelper.java src/main/resources/hudson/views/JobTypeFilter/config.jelly http://jenkins-ci.org/commit/view-job-filters-plugin/fb754c204acebc22c08111e5c4aa38f53e7d858a Log: [FIXED JENKINS-20522] Proper usage of TopLevelItemDescriptor.
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 152047 ] JNJira + In-Review [ 194186 ]

              People

              • Assignee:
                jacob_robertson Jacob Robertson
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: