Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21190

Add attribute-driven setup of norefresh in /lib/layout/layoit.jelly

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Similar Issues:

      Description

      The current implementation determines behavior by existence of "norefresh" attribute. Hence it is quite complex to dynamically define the behavior in parent jelly files

      It would be great to interpret norefresh="false" as "allows page refresh"

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/View.java
            core/src/main/resources/hudson/model/View/index.jelly
            core/src/main/resources/lib/layout/breadcrumbBar.jelly
            core/src/main/resources/lib/layout/layout.jelly
            http://jenkins-ci.org/commit/jenkins/5de6a8d06dbc2fe7e34bf8fb531c6588bbc77db8
            Log:
            JENKINS-21190 - lib/layout/layout.jelly: Interpret norefresh=="false" as "autorefresh is enabled"

            The fix allows to explicitly disable automatic page refreshes in the @View extensions.
            Resolves https://issues.jenkins-ci.org/browse/JENKINS-21190

            Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/View.java core/src/main/resources/hudson/model/View/index.jelly core/src/main/resources/lib/layout/breadcrumbBar.jelly core/src/main/resources/lib/layout/layout.jelly http://jenkins-ci.org/commit/jenkins/5de6a8d06dbc2fe7e34bf8fb531c6588bbc77db8 Log: JENKINS-21190 - lib/layout/layout.jelly: Interpret norefresh=="false" as "autorefresh is enabled" The fix allows to explicitly disable automatic page refreshes in the @View extensions. Resolves https://issues.jenkins-ci.org/browse/JENKINS-21190 Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/View.java
            http://jenkins-ci.org/commit/jenkins/4bb0f98901e2836688ae6c56b9f112c105bc1c54
            Log:
            [FIXED JENKINS-21190] [FIXED JENKINS-21191] Noting merge of #1082.

            Compare: https://github.com/jenkinsci/jenkins/compare/485cc150eaa3...4bb0f98901e2

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/View.java http://jenkins-ci.org/commit/jenkins/4bb0f98901e2836688ae6c56b9f112c105bc1c54 Log: [FIXED JENKINS-21190] [FIXED JENKINS-21191] Noting merge of #1082. Compare: https://github.com/jenkinsci/jenkins/compare/485cc150eaa3...4bb0f98901e2
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3238
            JENKINS-21190 - lib/layout/layout.jelly: Interpret norefresh=="false" as "autorefresh is enabled" (Revision 5de6a8d06dbc2fe7e34bf8fb531c6588bbc77db8)
            [FIXED JENKINS-21190] [FIXED JENKINS-21191] Noting merge of #1082. (Revision 4bb0f98901e2836688ae6c56b9f112c105bc1c54)

            Result = SUCCESS
            o.v.nenashev : 5de6a8d06dbc2fe7e34bf8fb531c6588bbc77db8
            Files :

            • core/src/main/resources/lib/layout/layout.jelly
            • core/src/main/resources/lib/layout/breadcrumbBar.jelly
            • core/src/main/java/hudson/model/View.java
            • core/src/main/resources/hudson/model/View/index.jelly

            Jesse Glick : 4bb0f98901e2836688ae6c56b9f112c105bc1c54
            Files :

            • core/src/main/java/hudson/model/View.java
            • changelog.html
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3238 JENKINS-21190 - lib/layout/layout.jelly: Interpret norefresh=="false" as "autorefresh is enabled" (Revision 5de6a8d06dbc2fe7e34bf8fb531c6588bbc77db8) [FIXED JENKINS-21190] [FIXED JENKINS-21191] Noting merge of #1082. (Revision 4bb0f98901e2836688ae6c56b9f112c105bc1c54) Result = SUCCESS o.v.nenashev : 5de6a8d06dbc2fe7e34bf8fb531c6588bbc77db8 Files : core/src/main/resources/lib/layout/layout.jelly core/src/main/resources/lib/layout/breadcrumbBar.jelly core/src/main/java/hudson/model/View.java core/src/main/resources/hudson/model/View/index.jelly Jesse Glick : 4bb0f98901e2836688ae6c56b9f112c105bc1c54 Files : core/src/main/java/hudson/model/View.java changelog.html

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: