Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21221

Add option for backing up of plugin archives, as well as arbitrary files

    Details

    • Similar Issues:

      Description

      Until now, plugins are archived as a list which makes Jenkins, when restored, re-download and re-install the plugins.
      Alternatively, there should be an option to archive the actual plugin archives themselves.
      Also, It is not possible to archive arbitrary files that aren't selected by the built-in filters. It would be useful to allow for an arbitrary regex pattern to select additional files, since oftentimes plugins use config files that fall outside of the backup set.

        Attachments

          Activity

          Hide
          tofuatjava Thomas Fürer added a comment -

          What's wrong with the idea to save only the meta data of the plugins and download/install it during restore operation? Why do you want to save data which already stored in the internet.
          Don't get me wrong I only want to understand your usecase, because I'm currently working an thinbackup 2.0 with several improvements.

          Show
          tofuatjava Thomas Fürer added a comment - What's wrong with the idea to save only the meta data of the plugins and download/install it during restore operation? Why do you want to save data which already stored in the internet. Don't get me wrong I only want to understand your usecase, because I'm currently working an thinbackup 2.0 with several improvements.
          Hide
          pmatignon Patrice Matignon added a comment -

          There is nothing wrong with backing up only the metadata, it's fast and storage-efficient for sure.

          As a matter of personal preferences, I prefer having the option of a full backup for a more straight-forward restore. I am looking at the following potential benefits:

          • offline restore, with no or controlled connectivity to the internet
          • 'manual' restore where the backed up ZIP can be restored manually to recreate an instance. That's also arguably an added safeguard that the restore should always be possible.
          • When the plugin mix includes some internally-developed plugins that were installed by uploading a .jpi/.hpi file, that can't be found on an update site.
          • By storing the .hpi/.jpi files along with the .disabled marker files, we can restore the exact plugin mix, including the plugins that were temporarily disabled. At least I don't believe the standard way allows for this.
          Show
          pmatignon Patrice Matignon added a comment - There is nothing wrong with backing up only the metadata, it's fast and storage-efficient for sure. As a matter of personal preferences, I prefer having the option of a full backup for a more straight-forward restore. I am looking at the following potential benefits: offline restore, with no or controlled connectivity to the internet 'manual' restore where the backed up ZIP can be restored manually to recreate an instance. That's also arguably an added safeguard that the restore should always be possible. When the plugin mix includes some internally-developed plugins that were installed by uploading a .jpi/.hpi file, that can't be found on an update site. By storing the .hpi/.jpi files along with the .disabled marker files, we can restore the exact plugin mix, including the plugins that were temporarily disabled. At least I don't believe the standard way allows for this.
          Hide
          tofuatjava Thomas Fürer added a comment -

          thanks for your answee and of course for your work too.

          I will include your thoughts in my work of a future version of thinbackup

          Show
          tofuatjava Thomas Fürer added a comment - thanks for your answee and of course for your work too. I will include your thoughts in my work of a future version of thinbackup
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Patrice Matignon
          Path:
          src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java
          src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPluginImpl.java
          src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/HudsonBackup.java
          src/main/resources/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink/backupsettings.jelly
          src/main/webapp/help/help-backupAdditionalFiles.html
          src/main/webapp/help/help-backupPlugins.html
          http://jenkins-ci.org/commit/thin-backup-plugin/e33602363860377849015bbb1939f604304813a9
          Log:
          JENKINS-21221: Add option for backing up of plugin archives, as well as arbitrary files.

          Proposed implementation

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Patrice Matignon Path: src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPluginImpl.java src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/HudsonBackup.java src/main/resources/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink/backupsettings.jelly src/main/webapp/help/help-backupAdditionalFiles.html src/main/webapp/help/help-backupPlugins.html http://jenkins-ci.org/commit/thin-backup-plugin/e33602363860377849015bbb1939f604304813a9 Log: JENKINS-21221 : Add option for backing up of plugin archives, as well as arbitrary files. Proposed implementation
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Thomas Fuerer
          Path:
          src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java
          src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPluginImpl.java
          src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/HudsonBackup.java
          src/main/resources/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink/backupsettings.jelly
          src/main/webapp/help/help-backupAdditionalFiles.html
          src/main/webapp/help/help-backupPlugins.html
          http://jenkins-ci.org/commit/thin-backup-plugin/728bc2534097c71a7b398de99808dd1d820ec7cc
          Log:
          Merge pull request #4 from patricematignon/master

          JENKINS-21221: Add option for backing up of plugin archives, as well arbitrary files

          Compare: https://github.com/jenkinsci/thin-backup-plugin/compare/0900a7ba03c0...728bc2534097

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thomas Fuerer Path: src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPluginImpl.java src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/HudsonBackup.java src/main/resources/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink/backupsettings.jelly src/main/webapp/help/help-backupAdditionalFiles.html src/main/webapp/help/help-backupPlugins.html http://jenkins-ci.org/commit/thin-backup-plugin/728bc2534097c71a7b398de99808dd1d820ec7cc Log: Merge pull request #4 from patricematignon/master JENKINS-21221 : Add option for backing up of plugin archives, as well arbitrary files Compare: https://github.com/jenkinsci/thin-backup-plugin/compare/0900a7ba03c0...728bc2534097
          Hide
          tofuatjava Thomas Fürer added a comment -

          UNSTABLE: Integrated in thinBackup #91
          JENKINS-21221: Add option for backing up of plugin archives, as well as arbitrary files. (pmatignon: e33602363860377849015bbb1939f604304813a9)

          • src/main/webapp/help/help-backupAdditionalFiles.html
          • src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/HudsonBackup.java
          • src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java
          • src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPluginImpl.java
          • src/main/webapp/help/help-backupPlugins.html
          • src/main/resources/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink/backupsettings.jelly
          Show
          tofuatjava Thomas Fürer added a comment - UNSTABLE: Integrated in thinBackup #91 JENKINS-21221 : Add option for backing up of plugin archives, as well as arbitrary files. (pmatignon: e33602363860377849015bbb1939f604304813a9 ) src/main/webapp/help/help-backupAdditionalFiles.html src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/HudsonBackup.java src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPluginImpl.java src/main/webapp/help/help-backupPlugins.html src/main/resources/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink/backupsettings.jelly
          Hide
          peer Peer Mueller added a comment -

          Would love to see this feature in the next release. Btw, when is a new release planned?

          Show
          peer Peer Mueller added a comment - Would love to see this feature in the next release. Btw, when is a new release planned?
          Hide
          pmatignon Patrice Matignon added a comment -

          The plugin changelog indicates this ticket was released as of 1.8.0 : should it be closed ?

          Show
          pmatignon Patrice Matignon added a comment - The plugin changelog indicates this ticket was released as of 1.8.0 : should it be closed ?

            People

            • Assignee:
              pmatignon Patrice Matignon
              Reporter:
              pmatignon Patrice Matignon
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: