Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21434

Git Client 1.5.0+ does not resolve reference repositories correctly (anymore)

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Since git-client 1.5.0, reference repositories are not correctly resolved anymore.

      Commit a3d3d548 (replace "clone" by "init+fetch" so we can configure git to use a local gitcrendentials store) introduced two problems:

      • alternates is made to point to <referencePath>/.git/objects which obviously can not work for bare reference repositories (which should be the rule).
      • alternates uses File.getAbsolutePath() which uses backslashes on windows systems. However, both msysgit and cygwin-git expect slashes as path divider

        Attachments

          Activity

          Hide
          paux Stephan Pauxberger added a comment -
          Show
          paux Stephan Pauxberger added a comment - Created Pull Request 74 ( https://github.com/jenkinsci/git-client-plugin/pull/74 )
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephan Pauxberger
          Path:
          src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
          http://jenkins-ci.org/commit/git-client-plugin/5b88253642fc70f0ba73175fc5e7eadc30d6bc5a
          Log:
          JENKINS-21434 Git Client 1.5.0+ does not resolve reference
          repositories correctly (anymore)

          • Check for existance of objects directory in reference dir.
          • handle bare reference repositories
          • replace backslashes with slashes for windows systems
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephan Pauxberger Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java http://jenkins-ci.org/commit/git-client-plugin/5b88253642fc70f0ba73175fc5e7eadc30d6bc5a Log: JENKINS-21434 Git Client 1.5.0+ does not resolve reference repositories correctly (anymore) Check for existance of objects directory in reference dir. handle bare reference repositories replace backslashes with slashes for windows systems
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De loof
          Path:
          src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
          http://jenkins-ci.org/commit/git-client-plugin/7b1a90594fd7ceb90aeb81cdbd9ceb20a474bc4e
          Log:
          Merge pull request #74 from pauxus/reference-fix

          JENKINS-21434 Git Client 1.5.0+ does not resolve reference

          Compare: https://github.com/jenkinsci/git-client-plugin/compare/e6d5057f8339...7b1a90594fd7

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java http://jenkins-ci.org/commit/git-client-plugin/7b1a90594fd7ceb90aeb81cdbd9ceb20a474bc4e Log: Merge pull request #74 from pauxus/reference-fix JENKINS-21434 Git Client 1.5.0+ does not resolve reference Compare: https://github.com/jenkinsci/git-client-plugin/compare/e6d5057f8339...7b1a90594fd7
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mark Waite
          Path:
          src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java
          http://jenkins-ci.org/commit/git-client-plugin/a7df8d724a9ab924e40014b5b603d183a0fc8d82
          Log:
          Test cases related to JENKINS-21434 - alternates file wrong content

          Checks that cloned copies have the alternates file with expected
          content when the clone is performed with a reference repository, and
          that cloned copies do not have the alternates file when clone does not
          use a reference repository.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java http://jenkins-ci.org/commit/git-client-plugin/a7df8d724a9ab924e40014b5b603d183a0fc8d82 Log: Test cases related to JENKINS-21434 - alternates file wrong content Checks that cloned copies have the alternates file with expected content when the clone is performed with a reference repository, and that cloned copies do not have the alternates file when clone does not use a reference repository.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De loof
          Path:
          src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java
          http://jenkins-ci.org/commit/git-client-plugin/dc35b60cf81f217bc64c911aefd9af127481d8cc
          Log:
          Merge pull request #77 from MarkEWaite/master-test-JENKINS-21434-fixed

          Test cases related to JENKINS-21434 - alternates file wrong content

          Compare: https://github.com/jenkinsci/git-client-plugin/compare/6d50b04f0a34...dc35b60cf81f

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java http://jenkins-ci.org/commit/git-client-plugin/dc35b60cf81f217bc64c911aefd9af127481d8cc Log: Merge pull request #77 from MarkEWaite/master-test- JENKINS-21434 -fixed Test cases related to JENKINS-21434 - alternates file wrong content Compare: https://github.com/jenkinsci/git-client-plugin/compare/6d50b04f0a34...dc35b60cf81f
          Hide
          markewaite Mark Waite added a comment -

          These changes have been included in git-client-plugin 1.6.2

          Show
          markewaite Mark Waite added a comment - These changes have been included in git-client-plugin 1.6.2

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              paux Stephan Pauxberger
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: