Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21746

LauncherDecorator should be able to override localhost location

    Details

    • Similar Issues:

      Description

      If a LauncherDecorator in fact runs a command on a different physical/virtual computer, as would be necessary to support running jobs inside some kind of container, then it also needs to be able to inform code like that in maven-plugin to use something other than InetAddress.getLocalHost to refer to the machine running the Jenkins slave agent. (TBD if anything other than replacing the hostname is necessary, e.g. defining a proxy port.)

        Attachments

          Issue Links

            Activity

            Show
            ndeloof Nicolas De Loof added a comment - see https://github.com/jenkinsci/jenkins/pull/1797
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De loof
            Path:
            maven3-agent/src/main/java/org/jvnet/hudson/maven3/agent/Maven3Main.java
            maven31-agent/src/main/java/jenkins/maven3/agent/Maven31Main.java
            maven32-agent/src/main/java/jenkins/maven3/agent/Maven32Main.java
            http://jenkins-ci.org/commit/maven-interceptors/baebe812350cd732fc6f257fe9d2ca38b4ea1b82
            Log:
            Merge pull request #8 from ndeloof/JENKINS-21746

            accept TCP communication socket parameter as `[ip:]port`

            Compare: https://github.com/jenkinsci/maven-interceptors/compare/5792f2a7f19f...baebe812350c

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: maven3-agent/src/main/java/org/jvnet/hudson/maven3/agent/Maven3Main.java maven31-agent/src/main/java/jenkins/maven3/agent/Maven31Main.java maven32-agent/src/main/java/jenkins/maven3/agent/Maven32Main.java http://jenkins-ci.org/commit/maven-interceptors/baebe812350cd732fc6f257fe9d2ca38b4ea1b82 Log: Merge pull request #8 from ndeloof/ JENKINS-21746 accept TCP communication socket parameter as ` [ip:] port` Compare: https://github.com/jenkinsci/maven-interceptors/compare/5792f2a7f19f...baebe812350c
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De loof
            Path:
            pom.xml
            src/main/java/hudson/maven/AbstractMavenProcessFactory.java
            src/main/java/hudson/maven/TcpSocketHostLocator.java
            http://jenkins-ci.org/commit/maven-plugin/1439cda2c1ca0863e2ca4ef0ed40be1c9af0e204
            Log:
            Merge pull request #51 from ndeloof/JENKINS-21746

            introduce TcpSocketHostLocator extension point

            Compare: https://github.com/jenkinsci/maven-plugin/compare/a598af0a555a...1439cda2c1ca

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: pom.xml src/main/java/hudson/maven/AbstractMavenProcessFactory.java src/main/java/hudson/maven/TcpSocketHostLocator.java http://jenkins-ci.org/commit/maven-plugin/1439cda2c1ca0863e2ca4ef0ed40be1c9af0e204 Log: Merge pull request #51 from ndeloof/ JENKINS-21746 introduce TcpSocketHostLocator extension point Compare: https://github.com/jenkinsci/maven-plugin/compare/a598af0a555a...1439cda2c1ca
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Jesse Glick Nicolas De Loof should we close it?

            Show
            oleg_nenashev Oleg Nenashev added a comment - Jesse Glick Nicolas De Loof should we close it?
            Hide
            jglick Jesse Glick added a comment -

            Not sure, I asked for clarification in the PR but Nicolas De Loof never responded.

            Show
            jglick Jesse Glick added a comment - Not sure, I asked for clarification in the PR but Nicolas De Loof never responded.

              People

              • Assignee:
                Unassigned
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: