Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22102

NodeJS plugin does not remember the saved "NodeJS Installation"

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In my job, I added an "Execute NodeJS script" build step. There I can choose between my three installed NodeJS Installation (as configured in the global Jenkins configuration).

      When I choose one installation from the popup, and save the job, it is saved fine, but as soon as I open the configuration page of the job again, the popup always shows the first NodeJS installation (and then if I save without changing anything, it will also save that wrong selection)

      Expected: The configured NodeJS installation should show in the popup, not the first one

        Attachments

          Activity

          Hide
          marc_guenther Marc Günther added a comment -

          BTW, the popup in the "Provide Node & npm bin/ folder to PATH" works perfectly fine.

          Show
          marc_guenther Marc Günther added a comment - BTW, the popup in the "Provide Node & npm bin/ folder to PATH" works perfectly fine.
          Hide
          unilama Marcin Stanisławski added a comment -

          The problem is typo bug in config.jelly

          Pull request created, https://github.com/jenkinsci/nodejs-plugin/pull/7

          Show
          unilama Marcin Stanisławski added a comment - The problem is typo bug in config.jelly Pull request created, https://github.com/jenkinsci/nodejs-plugin/pull/7
          Hide
          nfalco Nikolas Falco added a comment -

          I can confirm the issue.
          The PR#7 with recent changes on master does not work alone, it's necessary to expose getter and setter otherwise the value of nodeJSInstallationName could not be taken.

          Show
          nfalco Nikolas Falco added a comment - I can confirm the issue. The PR#7 with recent changes on master does not work alone, it's necessary to expose getter and setter otherwise the value of nodeJSInstallationName could not be taken.
          Hide
          nfalco Nikolas Falco added a comment -

          The PR was merged and the fix was completed with other commit.

          Show
          nfalco Nikolas Falco added a comment - The PR was merged and the fix was completed with other commit.
          Hide
          nfalco Nikolas Falco added a comment -

          I've attached a snapshot build with the changes so also you could test the bugfix.
          Due a previous refactor (more than one year ago) of this plugin to be compliant with more recent jenkins api if you have the envinject plugin the action of "Provide Node & npm bin/ folder to PATH" will not work because JENKINS-26583

          Show
          nfalco Nikolas Falco added a comment - I've attached a snapshot build with the changes so also you could test the bugfix. Due a previous refactor (more than one year ago) of this plugin to be compliant with more recent jenkins api if you have the envinject plugin the action of "Provide Node & npm bin/ folder to PATH" will not work because JENKINS-26583
          Hide
          nfalco Nikolas Falco added a comment -

          Released in 1.0

          Show
          nfalco Nikolas Falco added a comment - Released in 1.0

            People

            • Assignee:
              nfalco Nikolas Falco
              Reporter:
              marc_guenther Marc Günther
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: