Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22114

CPPCheck - when looking at the source code of an error - the latest source is used

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: cppcheck-plugin
    • Labels:
      None
    • Environment:
      Ubuntu
    • Similar Issues:

      Description

      When the CPPCheck shows an error, it points to a file in the workspace. The next run - when the bug is fixed - will overwrite the workspace, so there is no history possible of determining what got changed in the code to avoid the cppcheck warning/error in the first place... A better solution might be to archive the faulty file in the build results and point yo that file instead.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckPublisher.java
          http://jenkins-ci.org/commit/cppcheck-plugin/2afb683d4dd0ccac5b752438c73ef904d5bfb247
          Log:
          JENKINS-22114 CPPCheck - when looking at the source code of an error - the latest source is used

          • The files with source code were copied to the build directory only for builds on slave machine. Builds on master didn't copied any file and workspace files (with all updates) were shown for historical builds too. The code updated to always copy all neccessary files to the build directory to provide the current code even after it is updated in future.
          • Code for displaying of latest workspace files is still present, it is mainly for backward compatibility.
          • Condition "if directory doesn't exist, delete and create it" fixed - unneccessary/incorrect delete part removed.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckPublisher.java http://jenkins-ci.org/commit/cppcheck-plugin/2afb683d4dd0ccac5b752438c73ef904d5bfb247 Log: JENKINS-22114 CPPCheck - when looking at the source code of an error - the latest source is used The files with source code were copied to the build directory only for builds on slave machine. Builds on master didn't copied any file and workspace files (with all updates) were shown for historical builds too. The code updated to always copy all neccessary files to the build directory to provide the current code even after it is updated in future. Code for displaying of latest workspace files is still present, it is mainly for backward compatibility. Condition "if directory doesn't exist, delete and create it" fixed - unneccessary/incorrect delete part removed.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckPublisher.java
          http://jenkins-ci.org/commit/cppcheck-plugin/5a3e1d30b433a017063ca3c2f5c3e6baf35c38f5
          Log:
          Merge pull request #7 from mixalturek/master

          JENKINS-22114 CPPCheck - when looking at the source code of an error -...

          Compare: https://github.com/jenkinsci/cppcheck-plugin/compare/ce2c74bd41c8...5a3e1d30b433

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckSource.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckPublisher.java http://jenkins-ci.org/commit/cppcheck-plugin/5a3e1d30b433a017063ca3c2f5c3e6baf35c38f5 Log: Merge pull request #7 from mixalturek/master JENKINS-22114 CPPCheck - when looking at the source code of an error -... Compare: https://github.com/jenkinsci/cppcheck-plugin/compare/ce2c74bd41c8...5a3e1d30b433
          Hide
          mixalturek Michal Turek added a comment -

          Fixed, will be released in version 1.15.

          Show
          mixalturek Michal Turek added a comment - Fixed, will be released in version 1.15.

            People

            • Assignee:
              mixalturek Michal Turek
              Reporter:
              maurices Maurice Smulders
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: