Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22394

Ensure that collector runs after individual analysis publishers

    Details

    • Similar Issues:

      Description

      Analysis collector build step should check that all selected analysis plugins are running before the collection step. If not a warning or error should be shown.

        Attachments

          Issue Links

            Activity

            Hide
            moncreaff Greg Moncreaff added a comment -

            console log messages (interesting that analysis collector is before DRY, etc. I had it 1st in list since I wanted its graph to be top of Job splash page.

            00:02:18.992 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #737
            00:02:18.992 [DRY] Collecting duplicate code analysis files...
            00:02:18.995 [DRY] Finding all files that match the pattern bin/cpd.xml
            00:02:18.995 [DRY] Parsing 1 files in /var/lib/jenkins/workspace/zzz
            00:02:18.995 [DRY] Successfully parsed file /var/lib/jenkins/workspace/zzz/bin/cpd.xml of module with 15 warnings.
            00:02:19.005 [DRY] Computing warning deltas based on reference build #737
            00:02:19.007 [WARNINGS] Parsing warnings in console log with parser GNU C Compiler 4 (gcc)
            00:02:19.021 [WARNINGS] Computing warning deltas based on reference build #737
            00:02:19.021 [WARNINGS] Plug-in Result: Success - no threshold has been exceeded
            00:02:19.235 [TASKS] Scanning folder '/var/lib/jenkins/workspace/zzz' for files matching the pattern '*/.cpp, */.h' - excludes:
            00:02:19.235 [TASKS] Found 486 files to scan for tasks
            00:02:19.235 [TASKS] Found 138 open tasks.
            00:02:19.265 [TASKS] Computing warning deltas based on reference build #737

            not latest, our tool governance model typically imposes a one-two quarter lag, but reasonably current (this year anyway)

            Jenkins ver. 1.581
            Static Analysis Collector Plug-in 1.41

            I changed the publisher order to be
            1. DRY
            2. WARNINGS
            3. TASKS
            4. ANALYSIS-COLLECTOR

            and AH-HA! now I'm seeing something more reasonable in the graph.

            It looks like
            1. there is an (unobvious) dependency between the plugins, and
            2. order of graphs on the splash page can't be adjusted independently?

            As a minimum I'd recommend putting text on the base (not advanced) SA-Collector plugin configurator to say it needs to be below any of the plugins you want it to be summarizing. And the wiki should explain it more?....

            I don't know if core has any kind of dependency model for plugins to allow automatic reordering of execution? and allowing user to order the display (graphs) in some desired summary/details or priority high/low order in the job config, suspecting not?......

            Show
            moncreaff Greg Moncreaff added a comment - console log messages (interesting that analysis collector is before DRY, etc. I had it 1st in list since I wanted its graph to be top of Job splash page. 00:02:18.992 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #737 00:02:18.992 [DRY] Collecting duplicate code analysis files... 00:02:18.995 [DRY] Finding all files that match the pattern bin/cpd.xml 00:02:18.995 [DRY] Parsing 1 files in /var/lib/jenkins/workspace/zzz 00:02:18.995 [DRY] Successfully parsed file /var/lib/jenkins/workspace/zzz/bin/cpd.xml of module with 15 warnings. 00:02:19.005 [DRY] Computing warning deltas based on reference build #737 00:02:19.007 [WARNINGS] Parsing warnings in console log with parser GNU C Compiler 4 (gcc) 00:02:19.021 [WARNINGS] Computing warning deltas based on reference build #737 00:02:19.021 [WARNINGS] Plug-in Result: Success - no threshold has been exceeded 00:02:19.235 [TASKS] Scanning folder '/var/lib/jenkins/workspace/zzz' for files matching the pattern '* / .cpp, * / .h' - excludes: 00:02:19.235 [TASKS] Found 486 files to scan for tasks 00:02:19.235 [TASKS] Found 138 open tasks. 00:02:19.265 [TASKS] Computing warning deltas based on reference build #737 not latest, our tool governance model typically imposes a one-two quarter lag, but reasonably current (this year anyway) Jenkins ver. 1.581 Static Analysis Collector Plug-in 1.41 I changed the publisher order to be 1. DRY 2. WARNINGS 3. TASKS 4. ANALYSIS-COLLECTOR and AH-HA! now I'm seeing something more reasonable in the graph. It looks like 1. there is an (unobvious) dependency between the plugins, and 2. order of graphs on the splash page can't be adjusted independently? As a minimum I'd recommend putting text on the base (not advanced) SA-Collector plugin configurator to say it needs to be below any of the plugins you want it to be summarizing. And the wiki should explain it more?.... I don't know if core has any kind of dependency model for plugins to allow automatic reordering of execution? and allowing user to order the display (graphs) in some desired summary/details or priority high/low order in the job config, suspecting not?......
            Hide
            drulli Ulli Hafner added a comment -

            Interesting, since when is it possible to reorder post build steps? I defined the order of the actions in source code so that the collector plugin is always last. Seems that this could be changed now...

            The order of the graphs cannot be changed.

            Show
            drulli Ulli Hafner added a comment - Interesting, since when is it possible to reorder post build steps? I defined the order of the actions in source code so that the collector plugin is always last. Seems that this could be changed now... The order of the graphs cannot be changed.
            Hide
            danielbeck Daniel Beck added a comment -

            It appears this has been introduced with the addition of the dropdown, i.e. 1.463, May 2012. See https://groups.google.com/forum/?fromgroups#!topic/jenkinsci-dev/UQLvxQclyb4

            (I think the UI ignores behavior from Recorder/Notifier/needsToRunAfterFinalized though, so it's actually a bit confusing.)

            Show
            danielbeck Daniel Beck added a comment - It appears this has been introduced with the addition of the dropdown, i.e. 1.463, May 2012. See https://groups.google.com/forum/?fromgroups#!topic/jenkinsci-dev/UQLvxQclyb4 (I think the UI ignores behavior from Recorder/Notifier/needsToRunAfterFinalized though, so it's actually a bit confusing.)
            Hide
            drulli Ulli Hafner added a comment -

            Wow, that feature is quite old I never actually realized that...

            @Greg: I'll add a warning if the collector is not last.

            Show
            drulli Ulli Hafner added a comment - Wow, that feature is quite old I never actually realized that... @Greg: I'll add a warning if the collector is not last.
            Hide
            drulli Ulli Hafner added a comment - - edited

            Analysis collector will not be supported anymore. It will be integrated into the warnings plugin. See JENKINS-17168

            Show
            drulli Ulli Hafner added a comment - - edited Analysis collector will not be supported anymore. It will be integrated into the warnings plugin. See JENKINS-17168

              People

              • Assignee:
                drulli Ulli Hafner
                Reporter:
                moncreaff Greg Moncreaff
              • Votes:
                2 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: