Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2252

Mention SCM changeset ID in email

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: mercurial-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      MailSender does

      buf.append('[');
      buf.append(entry.getAuthor().getFullName());
      buf.append("] ");

      For Mercurial, it would be very useful to insert the changeset ID here as well.
      Similarly, for Subversion the commit number would be useful. Otherwise you need
      to click on the changelog, find the item mentioned in email, and look up its
      changeset ID there.

        Attachments

          Activity

          Hide
          jglick Jesse Glick added a comment -

          'mail' is probably a better component for this.

          Show
          jglick Jesse Glick added a comment - 'mail' is probably a better component for this.
          Hide
          jglick Jesse Glick added a comment -

          See also issue #583.

          Show
          jglick Jesse Glick added a comment - See also issue #583.
          Hide
          mindless Alan Harder added a comment -

          For svn this can be done with email-ext plugin's $CHANGES token and its format parameter, using %r for the revision.. not sure if mercurial supports this token. Can we close this issue?

          Show
          mindless Alan Harder added a comment - For svn this can be done with email-ext plugin's $CHANGES token and its format parameter, using %r for the revision.. not sure if mercurial supports this token. Can we close this issue?
          Hide
          jglick Jesse Glick added a comment -

          Not currently possible for Mercurial since ChangesSinceLastBuildContent.appendEntry uses reflection to look for a method 'getRevision', which MercurialChangeSet does not currently implement.

          (Making a concrete nonfinal impl in ChangeLogSet.Entry is not an option, since the return value is int in SubversionChangeLogSet.LogEntry, but would need to be String or similar for a DVCS like Mercurial.)

          Show
          jglick Jesse Glick added a comment - Not currently possible for Mercurial since ChangesSinceLastBuildContent.appendEntry uses reflection to look for a method 'getRevision', which MercurialChangeSet does not currently implement. (Making a concrete nonfinal impl in ChangeLogSet.Entry is not an option, since the return value is int in SubversionChangeLogSet.LogEntry, but would need to be String or similar for a DVCS like Mercurial.)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jglick
          Path:
          trunk/hudson/plugins/email-ext/src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastBuildContent.java
          http://jenkins-ci.org/commit/29774
          Log:
          JENKINS-2252 Correcting comments: (1) the SCM might not be Subversion; (2) copy-paste typo.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jglick Path: trunk/hudson/plugins/email-ext/src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastBuildContent.java http://jenkins-ci.org/commit/29774 Log: JENKINS-2252 Correcting comments: (1) the SCM might not be Subversion; (2) copy-paste typo.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jglick
          Path:
          trunk/hudson/plugins/email-ext/src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastBuildContent.java
          http://jenkins-ci.org/commit/29774
          Log:
          JENKINS-2252 Correcting comments: (1) the SCM might not be Subversion; (2) copy-paste typo.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jglick Path: trunk/hudson/plugins/email-ext/src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastBuildContent.java http://jenkins-ci.org/commit/29774 Log: JENKINS-2252 Correcting comments: (1) the SCM might not be Subversion; (2) copy-paste typo.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jglick
          Path:
          trunk/hudson/plugins/email-ext/src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastBuildContent.java
          http://jenkins-ci.org/commit/29774
          Log:
          JENKINS-2252 Correcting comments: (1) the SCM might not be Subversion; (2) copy-paste typo.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jglick Path: trunk/hudson/plugins/email-ext/src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastBuildContent.java http://jenkins-ci.org/commit/29774 Log: JENKINS-2252 Correcting comments: (1) the SCM might not be Subversion; (2) copy-paste typo.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: David M. Carr
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialChangeSet.java
          http://jenkins-ci.org/commit/mercurial-plugin/3dd018a8670bd467a9a13edd4feebeaa91351d09
          Log:
          JENKINS-2252 Enhance support for email-ext plugin by adding support for the %r pattern in ${CHANGES}

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: David M. Carr Path: src/main/java/hudson/plugins/mercurial/MercurialChangeSet.java http://jenkins-ci.org/commit/mercurial-plugin/3dd018a8670bd467a9a13edd4feebeaa91351d09 Log: JENKINS-2252 Enhance support for email-ext plugin by adding support for the %r pattern in ${CHANGES}
          Hide
          davidmc24 davidmc24 added a comment -

          Based on the comments on JENKINS-583, it doesn't sound like this is likely to be supported in the core mail support.

          With the next release of the mercurial plugin, this will be supported via the email-ext plugin. Use the %r format in the CHANGES format parameter.

          Show
          davidmc24 davidmc24 added a comment - Based on the comments on JENKINS-583 , it doesn't sound like this is likely to be supported in the core mail support. With the next release of the mercurial plugin, this will be supported via the email-ext plugin. Use the %r format in the CHANGES format parameter.
          Hide
          dogfood dogfood added a comment -

          Integrated in plugins_mercurial #83
          JENKINS-2252 Enhance support for email-ext plugin by adding support for the %r pattern in ${CHANGES}

          david :
          Files :

          • src/main/java/hudson/plugins/mercurial/MercurialChangeSet.java
          Show
          dogfood dogfood added a comment - Integrated in plugins_mercurial #83 JENKINS-2252 Enhance support for email-ext plugin by adding support for the %r pattern in ${CHANGES} david : Files : src/main/java/hudson/plugins/mercurial/MercurialChangeSet.java

            People

            • Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: