Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22631

OutOfOrderBuildMonitor fails to correct builds with duplicate number

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      A user reported a case where on occasion two distinct build records for a job shared the same build number. (The symlink pointed to the later one, and Jenkins loaded the later one, but this apparently caused problems for the Copy Artifact plugin.) The OOOBM did run, printing to the system log for example

      ... jenkins.diagnostics.ooom.Problem$Inspector scan
      WARNING: Multiple builds have the same number: /.../jobs/.../builds/2014-01-23_09-12-34:#18 vs /.../jobs/.../builds/2014-01-23_15-34-56:#18
      

      yet the older build record (/.../jobs/.../builds/2014-01-23_09-12-34/ in the above example) remained on disk, and no warning was displayed in the OOOBM log.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/jenkins/diagnostics/ooom/BuildPtr.java
          core/src/main/java/jenkins/diagnostics/ooom/Problem.java
          test/src/test/groovy/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest.groovy
          test/src/test/resources/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest/buildNumberClash.zip
          http://jenkins-ci.org/commit/jenkins/deb90a493c5341274fec11e653b44d7ad8b33586
          Log:
          [FIXED JENKINS-22631] Do not just warn about multiple builds with the same number; note this in the official problem list, and offer to fix it.

          Compare: https://github.com/jenkinsci/jenkins/compare/b36176736f80...deb90a493c53

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/jenkins/diagnostics/ooom/BuildPtr.java core/src/main/java/jenkins/diagnostics/ooom/Problem.java test/src/test/groovy/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest.groovy test/src/test/resources/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest/buildNumberClash.zip http://jenkins-ci.org/commit/jenkins/deb90a493c5341274fec11e653b44d7ad8b33586 Log: [FIXED JENKINS-22631] Do not just warn about multiple builds with the same number; note this in the official problem list, and offer to fix it. Compare: https://github.com/jenkinsci/jenkins/compare/b36176736f80...deb90a493c53
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3312
          [FIXED JENKINS-22631] Do not just warn about multiple builds with the same number; note this in the official problem list, and offer to fix it. (Revision deb90a493c5341274fec11e653b44d7ad8b33586)

          Result = UNSTABLE
          Jesse Glick : deb90a493c5341274fec11e653b44d7ad8b33586
          Files :

          • test/src/test/resources/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest/buildNumberClash.zip
          • test/src/test/groovy/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest.groovy
          • core/src/main/java/jenkins/diagnostics/ooom/Problem.java
          • core/src/main/java/jenkins/diagnostics/ooom/BuildPtr.java
          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3312 [FIXED JENKINS-22631] Do not just warn about multiple builds with the same number; note this in the official problem list, and offer to fix it. (Revision deb90a493c5341274fec11e653b44d7ad8b33586) Result = UNSTABLE Jesse Glick : deb90a493c5341274fec11e653b44d7ad8b33586 Files : test/src/test/resources/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest/buildNumberClash.zip test/src/test/groovy/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest.groovy core/src/main/java/jenkins/diagnostics/ooom/Problem.java core/src/main/java/jenkins/diagnostics/ooom/BuildPtr.java changelog.html
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/diagnostics/ooom/Problem.java
          http://jenkins-ci.org/commit/jenkins/1bf993caf5be57bfe8c1c4a80bfd51c38d683d5b
          Log:
          JENKINS-22631 The wrong (newer) build was sometimes being marked for fixing, depending on arbitrary directory listing order.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/diagnostics/ooom/Problem.java http://jenkins-ci.org/commit/jenkins/1bf993caf5be57bfe8c1c4a80bfd51c38d683d5b Log: JENKINS-22631 The wrong (newer) build was sometimes being marked for fixing, depending on arbitrary directory listing order.
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3314
          JENKINS-22631 The wrong (newer) build was sometimes being marked for fixing, depending on arbitrary directory listing order. (Revision 1bf993caf5be57bfe8c1c4a80bfd51c38d683d5b)

          Result = SUCCESS
          Jesse Glick : 1bf993caf5be57bfe8c1c4a80bfd51c38d683d5b
          Files :

          • core/src/main/java/jenkins/diagnostics/ooom/Problem.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3314 JENKINS-22631 The wrong (newer) build was sometimes being marked for fixing, depending on arbitrary directory listing order. (Revision 1bf993caf5be57bfe8c1c4a80bfd51c38d683d5b) Result = SUCCESS Jesse Glick : 1bf993caf5be57bfe8c1c4a80bfd51c38d683d5b Files : core/src/main/java/jenkins/diagnostics/ooom/Problem.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/diagnostics/ooom/Problem.java
          http://jenkins-ci.org/commit/jenkins/d7d566c1de5da1b65871cc5813b6efd8fe732230
          Log:
          JENKINS-22631 The wrong (newer) build was sometimes being marked for fixing, depending on arbitrary directory listing order.
          (cherry picked from commit 1bf993caf5be57bfe8c1c4a80bfd51c38d683d5b)

          Conflicts:
          core/src/main/java/jenkins/diagnostics/ooom/Problem.java

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/diagnostics/ooom/Problem.java http://jenkins-ci.org/commit/jenkins/d7d566c1de5da1b65871cc5813b6efd8fe732230 Log: JENKINS-22631 The wrong (newer) build was sometimes being marked for fixing, depending on arbitrary directory listing order. (cherry picked from commit 1bf993caf5be57bfe8c1c4a80bfd51c38d683d5b) Conflicts: core/src/main/java/jenkins/diagnostics/ooom/Problem.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/diagnostics/ooom/BuildPtr.java
          core/src/main/java/jenkins/diagnostics/ooom/Problem.java
          test/src/test/groovy/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest.groovy
          test/src/test/resources/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest/buildNumberClash.zip
          http://jenkins-ci.org/commit/jenkins/4417793b15525eef1477f2e3ed7f91f8f4a96fd8
          Log:
          [FIXED JENKINS-22631] Do not just warn about multiple builds with the same number; note this in the official problem list, and offer to fix it.
          (cherry picked from commit deb90a493c5341274fec11e653b44d7ad8b33586)

          Conflicts:
          changelog.html
          core/src/main/java/jenkins/diagnostics/ooom/Problem.java

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/diagnostics/ooom/BuildPtr.java core/src/main/java/jenkins/diagnostics/ooom/Problem.java test/src/test/groovy/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest.groovy test/src/test/resources/jenkins/diagnostics/ooom/OutOfOrderBuildDetectorTest/buildNumberClash.zip http://jenkins-ci.org/commit/jenkins/4417793b15525eef1477f2e3ed7f91f8f4a96fd8 Log: [FIXED JENKINS-22631] Do not just warn about multiple builds with the same number; note this in the official problem list, and offer to fix it. (cherry picked from commit deb90a493c5341274fec11e653b44d7ad8b33586) Conflicts: changelog.html core/src/main/java/jenkins/diagnostics/ooom/Problem.java

            People

            • Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: