Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22778

Changelog entries for SVN externals were broken in 2.0

    Details

    • Similar Issues:

      Description

      This commit broke changelog entries from external locations. Even with the proposed solution to JENKINS-22199 the paths remain broken (presumably except for the JENKINS-18574 use case).

      From the linked commit's discussion (see full discussion for context):

      But that's still not the actual problem! Since /trunk/baz/baz doesn't exist anywhere except for a local working copy, it will break all repo browsers even when implemented "correctly": .../repo2/trunk/baz/ simply does not exist as an actual path. And even if there is a repo browser that supports "virtual" paths for browsing, it won't be able to show the diff between two revisions of a completely different repository: Given the revisions in my test setup above, it's likely to result in links to something like http://svnbrowser/repo2/trunk/baz/baz?rev=4, when that revision doesn't even exist in that repo.

      I also tested the "exclude paths" option: While the changelog now shows the changed path baz/baz, I have to exclude the location /projectX/trunk/.* to ignore it. Which is obviously really confusing: how do you get from an accidentally polling-triggered build's change log to the correct location to exclude in the configuration? It's trivial in the old format, you just copy and paste from the change log.

      And while we're at it, changelog.xml lost the information about what kind of entity this is (tested with the master snapshot build):

      <path action="M" kind="unknown">baz/baz</path>
      

      as opposed to:

      <path action="M" kind="file">/projectX/trunk/baz</path>
      

      Solutions to JENKINS-18574 should not break the recording of changed paths and the repo browsers depending on those paths.

        Attachments

          Issue Links

            Activity

            Show
            danielbeck Daniel Beck added a comment - https://github.com/jenkinsci/subversion-plugin/pull/78
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
            src/main/java/hudson/scm/SubversionChangeLogBuilder.java
            src/test/java/hudson/scm/SubversionSCMTest.java
            http://jenkins-ci.org/commit/subversion-plugin/929864e62792091585ac4d4bf7710fd708841c1f
            Log:
            Merge pull request #78 from daniel-beck/JENKINS-22778

            [FIXED JENKINS-22778] Revert JENKINS-18574 related changes

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/a923c5011464...929864e62792

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/test/java/hudson/scm/SubversionSCMTest.java http://jenkins-ci.org/commit/subversion-plugin/929864e62792091585ac4d4bf7710fd708841c1f Log: Merge pull request #78 from daniel-beck/ JENKINS-22778 [FIXED JENKINS-22778] Revert JENKINS-18574 related changes Compare: https://github.com/jenkinsci/subversion-plugin/compare/a923c5011464...929864e62792
            Hide
            kutzi kutzi added a comment -

            Fixed by reverting JENKINS-18574

            Show
            kutzi kutzi added a comment - Fixed by reverting JENKINS-18574

              People

              • Assignee:
                kutzi kutzi
                Reporter:
                danielbeck Daniel Beck
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: