Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22875

Image does not appear on "Embeddable Build Status" page or in Github

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I'm using version 1.4 of the plugin, and I couldn't get the image to show up in GitHub. I finally realized that the image isn't showing up anywhere at all. When I click on the "Embeddable Build Status" link in a job, the image does not appear on the page, nor can I view the image by viewing the image URL directly. I've granted the "ViewStatus" permission to everyone, but still no luck. Am I missing something, or is it plain broken?

        Attachments

          Issue Links

            Activity

            Hide
            sfeldman Sean Feldman added a comment -

            Experiencing the same problem.
            Used fiddler to watch what headers are returned, and didn't see "Cache-Control: no-cache" coming down (according to this thread it is needed - https://github.com/github/markup/issues/224)

            Version:1.4
            Header for response:

            HTTP/1.1 200 OK
            Date: Thu, 22 May 2014 02:18:19 GMT
            ETag: /static/1a041373/success.png
            Expires: Fri, 01 Jan 1984 00:00:00 GMT
            Content-Type: image/png
            Content-Length: 2339
            Server: Jetty(8.y.z-SNAPSHOT)
            proxy-connection: keep-alive
            keep-alive: 60
            via: HTTP/1.1 proxy2444

            Show
            sfeldman Sean Feldman added a comment - Experiencing the same problem. Used fiddler to watch what headers are returned, and didn't see "Cache-Control: no-cache" coming down (according to this thread it is needed - https://github.com/github/markup/issues/224 ) Version:1.4 Header for response: HTTP/1.1 200 OK Date: Thu, 22 May 2014 02:18:19 GMT ETag: /static/1a041373/success.png Expires: Fri, 01 Jan 1984 00:00:00 GMT Content-Type: image/png Content-Length: 2339 Server: Jetty(8.y.z-SNAPSHOT) proxy-connection: keep-alive keep-alive: 60 via: HTTP/1.1 proxy2444
            Hide
            sfeldman Sean Feldman added a comment -

            This is a confirmed bug. Following can demonstrate it:
            curl -I "http://mybuildserver:8080/buildStatus/icon?job=myjob"
            HTTP/1.1 200 OK
            ETag: /static/1a041373/success.png
            Expires: Fri, 01 Jan 1984 00:00:00 GMT
            Content-Type: image/png
            Content-Length: 2339
            Server: Jetty(8.y.z-SNAPSHOT)

            As you can see,
            Cache-Control: no-cache is omitted and not returned, causing github to cache the image.

            Show
            sfeldman Sean Feldman added a comment - This is a confirmed bug. Following can demonstrate it: curl -I "http://mybuildserver:8080/buildStatus/icon?job=myjob" HTTP/1.1 200 OK ETag: /static/1a041373/success.png Expires: Fri, 01 Jan 1984 00:00:00 GMT Content-Type: image/png Content-Length: 2339 Server: Jetty(8.y.z-SNAPSHOT) As you can see, Cache-Control: no-cache is omitted and not returned, causing github to cache the image.
            Hide
            mgedmin Marius Gedminas added a comment -
            Show
            mgedmin Marius Gedminas added a comment - I think this was fixed by https://github.com/jenkinsci/embeddable-build-status-plugin/commit/6a97c7f95c348968c4f400a6b30fe7475e8a39f9 and released in version 1.5.
            Hide
            thomas_dee Thomas Döring added a comment -

            Resolved with v1.5

            Show
            thomas_dee Thomas Döring added a comment - Resolved with v1.5

              People

              • Assignee:
                kohsuke Kohsuke Kawaguchi
                Reporter:
                kjacobsen Karla Jacobsen
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: