Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22934

Rules for showing/hiding SCMTrigger.pollingThreadCount option are broken

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The option for the thread count for SCM polling is only shown when there are more than 10 items in Jenkins.

      This can have fatal (for Jenkins) consequences:

      • Folders support: The option is not shown if you have e.g. ~5 folders with 4k items each, a situation that likely warrants a sane limit to the number of parallel polling operations.
      • The option is hidden when the number of jobs drops below 10, and any form submit results in the default 0 (no thread limit) being set.

      Both combined can quickly kill large Jenkins instances.

        Attachments

          Activity

          Show
          danielbeck Daniel Beck added a comment - https://github.com/jenkinsci/jenkins/pull/1230
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/triggers/SCMTrigger.java
          core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
          http://jenkins-ci.org/commit/jenkins/e4902e7e8ab7a21e84ea21a36395b0e2a5077019
          Log:
          [FIXED JENKINS-22934] Show poll thread count option when necessary.

          • Show the option when the configured value is not the default
          • Show the option even when projects are in other ItemGroups
          • Only consider AbstractProjects
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly http://jenkins-ci.org/commit/jenkins/e4902e7e8ab7a21e84ea21a36395b0e2a5077019 Log: [FIXED JENKINS-22934] Show poll thread count option when necessary. Show the option when the configured value is not the default Show the option even when projects are in other ItemGroups Only consider AbstractProjects
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/triggers/SCMTrigger.java
          core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
          http://jenkins-ci.org/commit/jenkins/91ef9113262359ab45ed710d6ecad0f73df7b434
          Log:
          Merge pull request #1230 from daniel-beck/JENKINS-22934

          [FIXED JENKINS-22934] Show poll thread count option when necessary.

          Compare: https://github.com/jenkinsci/jenkins/compare/1b81efbdf342...91ef91132623

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly http://jenkins-ci.org/commit/jenkins/91ef9113262359ab45ed710d6ecad0f73df7b434 Log: Merge pull request #1230 from daniel-beck/ JENKINS-22934 [FIXED JENKINS-22934] Show poll thread count option when necessary. Compare: https://github.com/jenkinsci/jenkins/compare/1b81efbdf342...91ef91132623
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3419
          [FIXED JENKINS-22934] Show poll thread count option when necessary. (Revision e4902e7e8ab7a21e84ea21a36395b0e2a5077019)

          Result = SUCCESS
          daniel-beck : e4902e7e8ab7a21e84ea21a36395b0e2a5077019
          Files :

          • core/src/main/java/hudson/triggers/SCMTrigger.java
          • core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3419 [FIXED JENKINS-22934] Show poll thread count option when necessary. (Revision e4902e7e8ab7a21e84ea21a36395b0e2a5077019) Result = SUCCESS daniel-beck : e4902e7e8ab7a21e84ea21a36395b0e2a5077019 Files : core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/triggers/SCMTrigger.java
          core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
          http://jenkins-ci.org/commit/jenkins/7860c4e62003617c6fbb16d71c9eccfde9f10db7
          Log:
          [FIXED JENKINS-22934] Show poll thread count option when necessary.

          • Show the option when the configured value is not the default
          • Show the option even when projects are in other ItemGroups
          • Only consider AbstractProjects

          (cherry picked from commit e4902e7e8ab7a21e84ea21a36395b0e2a5077019)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly http://jenkins-ci.org/commit/jenkins/7860c4e62003617c6fbb16d71c9eccfde9f10db7 Log: [FIXED JENKINS-22934] Show poll thread count option when necessary. Show the option when the configured value is not the default Show the option even when projects are in other ItemGroups Only consider AbstractProjects (cherry picked from commit e4902e7e8ab7a21e84ea21a36395b0e2a5077019)

            People

            • Assignee:
              danielbeck Daniel Beck
              Reporter:
              danielbeck Daniel Beck
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: