Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22941

Way to mark an Executable that should not block isReadyToRestart

    Details

    • Similar Issues:

      Description

      If you have a Queue.Executable that should consume an executor (so is not from a FlyweightTask), it unconditionally blocks "safe restart": RestartListener.Default merely checks for the existence of at least one busy executor. For an executable using the durable-task plugin or similar, this is undesirable, since the task can in fact survive a Jenkins restart. There should be a way to mark an Executable (or its parent Task) as not blocking restart.

      There is already NonBlockingTask but this controls whether the task can be scheduled while Jenkins is quieting down, while this issue pertains to tasks which are already running and are safe to interrupt.

      As an aside, Jenkins.doSafeExit inexplicably has its own copy of safe shutdown code which neglects to use doQuietDown(true, 0) like doSafeRestart does, and thus does not consider RestartListener.

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Labels api api workflow
            jglick Jesse Glick made changes -
            Remote Link This issue links to "Workflow Trello card (Web Link)" [ 11700 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "Workflow Trello card (Web Link)" [ 11700 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-25938 [ JENKINS-25938 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-26900 [ JENKINS-26900 ]
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 1610 (Web Link)" [ 12177 ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jglick Jesse Glick made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            jglick Jesse Glick made changes -
            Status Reopened [ 4 ] Open [ 1 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-32015 [ JENKINS-32015 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 155088 ] JNJira + In-Review [ 195131 ]
            abayer Andrew Bayer made changes -
            Labels api workflow api pipeline workflow
            abayer Andrew Bayer made changes -
            Labels api pipeline workflow api pipeline

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: