Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22966

Combination filters are not handled well ( our case 11480 )

    Details

    • Similar Issues:

      Description

      Situations in which a configuration is excluded from being built by the combination filter are handled in a very confusing way in Matrix Reloaded plugin. The problems are the following:

      1. Configuration changes are not detected properly - the warning on the configuration selection page is always shown, even when there was no change in the configuration. IMHO the message provides very little value anyway and I would suggest it is not displayed at all.
      2. Combination filter is not visible in any way in the matrix, but it is applied (as it should be). As a result, you select a set of configurations to reload, but only a subset of those is actually run, getting filtered out by the combination filter afterwards. It would be very useful if those configurations were highlighted on the main page in some way. Such highlighting could replace the configuration change warning. Obviously we cannot detect them reliably if the filter itself contains build parameters, but filtering out other cases would be very useful anyway.

        Attachments

          Activity

          Hide
          mcupak Miro Cupak added a comment -

          Suggestion for a solution in this PR: https://github.com/jenkinsci/Matrix-Reloaded-Plugin/pull/7

          Show
          mcupak Miro Cupak added a comment - Suggestion for a solution in this PR: https://github.com/jenkinsci/Matrix-Reloaded-Plugin/pull/7
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: mcupak
          Path:
          src/main/resources/net/praqma/jenkins/plugin/reloaded/MatrixReloadedAction/index.jelly
          http://jenkins-ci.org/commit/Matrix-Reloaded-Plugin/d31d7a865d89ec7acf16dc25a9c55815a8b6d930
          Log:
          [FIXED JENKINS-22966] configurations filtered out by the combination filter are highlighted in the matrix - this replaces the config change warning message, which was not working properly anyway

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: mcupak Path: src/main/resources/net/praqma/jenkins/plugin/reloaded/MatrixReloadedAction/index.jelly http://jenkins-ci.org/commit/Matrix-Reloaded-Plugin/d31d7a865d89ec7acf16dc25a9c55815a8b6d930 Log: [FIXED JENKINS-22966] configurations filtered out by the combination filter are highlighted in the matrix - this replaces the config change warning message, which was not working properly anyway
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: mcupak
          Path:
          src/main/resources/net/praqma/jenkins/plugin/reloaded/MatrixReloadedAction/index.jelly
          http://jenkins-ci.org/commit/Matrix-Reloaded-Plugin/66f223501d4b7ff22367a94ea4570b8e03f23ab5
          Log:
          JENKINS-22966 extended matrix configuration to 0/1-dimensional matrices

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: mcupak Path: src/main/resources/net/praqma/jenkins/plugin/reloaded/MatrixReloadedAction/index.jelly http://jenkins-ci.org/commit/Matrix-Reloaded-Plugin/66f223501d4b7ff22367a94ea4570b8e03f23ab5 Log: JENKINS-22966 extended matrix configuration to 0/1-dimensional matrices
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mads Nielsen
          Path:
          src/main/resources/net/praqma/jenkins/plugin/reloaded/MatrixReloadedAction/index.jelly
          http://jenkins-ci.org/commit/Matrix-Reloaded-Plugin/234bf4aec81eb3d39d98d119ae32724fcb6c5a9c
          Log:
          Merge pull request #7 from mcupak/combination-filter

          [FIXED JENKINS-22966] configurations filtered out by the combination fil...

          Compare: https://github.com/jenkinsci/Matrix-Reloaded-Plugin/compare/ec270420ce41...234bf4aec81e

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mads Nielsen Path: src/main/resources/net/praqma/jenkins/plugin/reloaded/MatrixReloadedAction/index.jelly http://jenkins-ci.org/commit/Matrix-Reloaded-Plugin/234bf4aec81eb3d39d98d119ae32724fcb6c5a9c Log: Merge pull request #7 from mcupak/combination-filter [FIXED JENKINS-22966] configurations filtered out by the combination fil... Compare: https://github.com/jenkinsci/Matrix-Reloaded-Plugin/compare/ec270420ce41...234bf4aec81e

            People

            • Assignee:
              praqma Praqma Support
              Reporter:
              mcupak Miro Cupak
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: