Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23151

codemirror-mode on f:textarea broken (was: Execute shell build step text not saved properly)

    Details

    • Similar Issues:

      Description

      When I create a simple project and add Execute shell task,
      after save, the task contents are empty.
      config.xml on the server is empty too:

      <hudson.tasks.Shell><command/></hudson.tasks.Shell>
      

      When editing the config a second time, the contents are saved properly.
      Each consecutive add of shell task requires a second edit.

      When using inheritance plugin, there is no way to workaround the bug, since each edit creates new revision, and all shell tasks are empty.

      I tested it on 1.563 and 1.564

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Thanks, I was too lazy to do that myself!

            Show
            jglick Jesse Glick added a comment - Thanks, I was too lazy to do that myself!
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/resources/hudson/tasks/Shell/config.groovy
            http://jenkins-ci.org/commit/jenkins/f3848d2d4865bb5eab1ff0ae0bfdf90aab76b138
            Log:
            JENKINS-23151 Need to revert part of 5789f0c since codemirror-mode on f:textarea apparently does not work for lazy-load fragments.

            (cherry picked from commit 7f7eb60bdd4aa55f0d56c21ef04c12d4922399e4)

            Conflicts:
            changelog.html

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/hudson/tasks/Shell/config.groovy http://jenkins-ci.org/commit/jenkins/f3848d2d4865bb5eab1ff0ae0bfdf90aab76b138 Log: JENKINS-23151 Need to revert part of 5789f0c since codemirror-mode on f:textarea apparently does not work for lazy-load fragments. (cherry picked from commit 7f7eb60bdd4aa55f0d56c21ef04c12d4922399e4) Conflicts: changelog.html
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Vojtech Juranek
            Path:
            core/src/main/resources/hudson/tasks/Shell/config.groovy
            core/src/main/resources/lib/form/textarea/textarea.js
            http://jenkins-ci.org/commit/jenkins/4e48eaa05ca3a76fcb0e1eee307fd20f222079bc
            Log:
            [FIXED JENKINS-23151, JENKINS-23026] Save CodeMirror editor when it loses focus

            • Save CM editor when it loses focus to ensure that test is saved back to textarea
            • Turn on again CM editor for shell scripts
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: core/src/main/resources/hudson/tasks/Shell/config.groovy core/src/main/resources/lib/form/textarea/textarea.js http://jenkins-ci.org/commit/jenkins/4e48eaa05ca3a76fcb0e1eee307fd20f222079bc Log: [FIXED JENKINS-23151, JENKINS-23026] Save CodeMirror editor when it loses focus Save CM editor when it loses focus to ensure that test is saved back to textarea Turn on again CM editor for shell scripts
            Hide
            danielbeck Daniel Beck added a comment -

            vjuranek This should be resolved, right?

            Show
            danielbeck Daniel Beck added a comment - vjuranek This should be resolved, right?
            Hide
            danielbeck Daniel Beck added a comment -

            Should be fixed since Jan 2015.

            Show
            danielbeck Daniel Beck added a comment - Should be fixed since Jan 2015.

              People

              • Assignee:
                Unassigned
                Reporter:
                sobczyk Szymon S
              • Votes:
                5 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: