Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23348

changes to selenium configuration under jenkins 'manager jenkins' is not saved

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: selenium-plugin
    • Labels:
    • Environment:
      jenkins selenium plugin version: 2.4.1
      Jenkins version: 1.565
      OS: Win2k8 R2
    • Similar Issues:

      Description

      Problem:
      Data entered into jenkins admin selenium section is not saved

      1. As a jenkins admin, goto 'Manage Jenkins' -> Configure Systems -> Expand 'Selenium' Advance section
      2. Enter Set -newSessionWaitTimeout as 300000 (5mins) for new new test to timeout after waiting for a node.
      3. Click apply/Save
      4. Open Configure Systems -> Expand 'Selenium', this entered data will not be available

      We need to configure this -newSessionWaitTimeout as we are lots of test than the available number of nodes so we need to configure the time for new tests to wait for freed slots.
      Can we get this fix please ?

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleksandr Kulychok
            Path:
            src/main/java/hudson/plugins/selenium/PluginImpl.java
            src/main/java/hudson/plugins/selenium/configuration/global/hostname/JenkinsRootHostnameResolver.java
            src/main/java/hudson/plugins/selenium/configuration/global/hostname/StaticHostnameResolver.java
            src/main/resources/hudson/plugins/selenium/PluginImpl/config.jelly
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-browserTimeout.html
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-newSessionWaitTimeout.html
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-rcLog.html
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-rcLog_ja.html
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-timeout.html
            http://jenkins-ci.org/commit/selenium-plugin/76f88f59284d97d5edacca36ddaa8282404b76db
            Log:
            1. Fix https://issues.jenkins-ci.org/browse/JENKINS-23348 - selenium configuration under jenkins 'manager jenkins' is not saved.
            2. Remove deprecated and unused parameters from Configure System page: -rcDebug, -rcLog
            3. Add parameter -browserTimeout
            4. Set correct description for parameter -timeout (it was changed since selenium v2.21)
            5. Remove code which terminates starting selenium node in #startSeleniumNode() in case getHostName() returns null. Reason: node hostname can be manually configured on node in case it is non-discoverable from master. In such case node will successfully starts.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleksandr Kulychok Path: src/main/java/hudson/plugins/selenium/PluginImpl.java src/main/java/hudson/plugins/selenium/configuration/global/hostname/JenkinsRootHostnameResolver.java src/main/java/hudson/plugins/selenium/configuration/global/hostname/StaticHostnameResolver.java src/main/resources/hudson/plugins/selenium/PluginImpl/config.jelly src/main/resources/hudson/plugins/selenium/PluginImpl/help-browserTimeout.html src/main/resources/hudson/plugins/selenium/PluginImpl/help-newSessionWaitTimeout.html src/main/resources/hudson/plugins/selenium/PluginImpl/help-rcLog.html src/main/resources/hudson/plugins/selenium/PluginImpl/help-rcLog_ja.html src/main/resources/hudson/plugins/selenium/PluginImpl/help-timeout.html http://jenkins-ci.org/commit/selenium-plugin/76f88f59284d97d5edacca36ddaa8282404b76db Log: 1. Fix https://issues.jenkins-ci.org/browse/JENKINS-23348 - selenium configuration under jenkins 'manager jenkins' is not saved. 2. Remove deprecated and unused parameters from Configure System page: -rcDebug, -rcLog 3. Add parameter -browserTimeout 4. Set correct description for parameter -timeout (it was changed since selenium v2.21) 5. Remove code which terminates starting selenium node in #startSeleniumNode() in case getHostName() returns null. Reason: node hostname can be manually configured on node in case it is non-discoverable from master. In such case node will successfully starts.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleksandr Kulychok
            Path:
            src/main/java/hudson/plugins/selenium/PluginImpl.java
            src/main/java/hudson/plugins/selenium/configuration/global/hostname/JenkinsRootHostnameResolver.java
            src/main/java/hudson/plugins/selenium/configuration/global/hostname/StaticHostnameResolver.java
            src/main/resources/hudson/plugins/selenium/PluginImpl/config.jelly
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-browserTimeout.html
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-newSessionWaitTimeout.html
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-rcLog.html
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-rcLog_ja.html
            src/main/resources/hudson/plugins/selenium/PluginImpl/help-timeout.html
            http://jenkins-ci.org/commit/selenium-plugin/1e3486b0ebb77f47ee940698700482311f8bdce9
            Log:
            1. Fix https://issues.jenkins-ci.org/browse/JENKINS-23348 - selenium configuration under jenkins 'manager jenkins' is not saved.
            2. Remove deprecated and unused parameters from Configure System page: -rcDebug, -rcLog
            3. Add parameter -browserTimeout
            4. Set correct description for parameter -timeout (it was changed since selenium v2.21)
            5. Remove code which terminates starting selenium node in #startSeleniumNode() in case getHostName() returns null. Reason: node hostname can be manually configured on node in case it is non-discoverable from master. In such case node will successfully starts.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleksandr Kulychok Path: src/main/java/hudson/plugins/selenium/PluginImpl.java src/main/java/hudson/plugins/selenium/configuration/global/hostname/JenkinsRootHostnameResolver.java src/main/java/hudson/plugins/selenium/configuration/global/hostname/StaticHostnameResolver.java src/main/resources/hudson/plugins/selenium/PluginImpl/config.jelly src/main/resources/hudson/plugins/selenium/PluginImpl/help-browserTimeout.html src/main/resources/hudson/plugins/selenium/PluginImpl/help-newSessionWaitTimeout.html src/main/resources/hudson/plugins/selenium/PluginImpl/help-rcLog.html src/main/resources/hudson/plugins/selenium/PluginImpl/help-rcLog_ja.html src/main/resources/hudson/plugins/selenium/PluginImpl/help-timeout.html http://jenkins-ci.org/commit/selenium-plugin/1e3486b0ebb77f47ee940698700482311f8bdce9 Log: 1. Fix https://issues.jenkins-ci.org/browse/JENKINS-23348 - selenium configuration under jenkins 'manager jenkins' is not saved. 2. Remove deprecated and unused parameters from Configure System page: -rcDebug, -rcLog 3. Add parameter -browserTimeout 4. Set correct description for parameter -timeout (it was changed since selenium v2.21) 5. Remove code which terminates starting selenium node in #startSeleniumNode() in case getHostName() returns null. Reason: node hostname can be manually configured on node in case it is non-discoverable from master. In such case node will successfully starts.
            Hide
            kool79 Oleksandr Kulychok added a comment -

            Resolved in merged pull-request #44

            Show
            kool79 Oleksandr Kulychok added a comment - Resolved in merged pull-request #44
            Hide
            cnagaraju Chinmayee Nagaraju added a comment -

            I am using Jenkins ver 1.624 and Selenium plugin version 2.4.1 , I still don't see the timeout parameters being saved.
            Also, i need to add -browserTimeout as well. Do not see that option.
            Am I missing something ?

            Show
            cnagaraju Chinmayee Nagaraju added a comment - I am using Jenkins ver 1.624 and Selenium plugin version 2.4.1 , I still don't see the timeout parameters being saved. Also, i need to add -browserTimeout as well. Do not see that option. Am I missing something ?
            Hide
            cnagaraju Chinmayee Nagaraju added a comment -

            I am on Windows 8.1 x64 machine

            Show
            cnagaraju Chinmayee Nagaraju added a comment - I am on Windows 8.1 x64 machine

              People

              • Assignee:
                darkrift Richard Lavoie
                Reporter:
                aragavan ragavan Ambighananthan
              • Votes:
                7 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: