Details

    • Similar Issues:

      Description

      There has been various changes made to YUI copies in Jenkins, but this is dangerous as these YUI scripts are generated and copied verbatim from the upstream.

      YUI2 is deprecated upstream, so we should fork that into the jenkinsci org and apply patches there. We can then run the YUI build script and integrate the resulting bits (perhaps as an adjunct so that people won't modify them in place.)

      This issue is to track this task.

        Attachments

          Activity

          Hide
          tfennelly Tom FENNELLY added a comment -

          They released 2.9.0, but no tag or clear commit (that I can see) that marks the release. https://github.com/yui/yui2

          I'm guessing it's https://github.com/yui/yui2/commit/2f98f3692ba447d8b0931b64f645ae1d5acc01ee

          Do we fork the repo and branch from the 2.9.0 release commit (once we figure it out), or are we going to take all the commits to the YUi2 since the 2.9.0 release?

          Show
          tfennelly Tom FENNELLY added a comment - They released 2.9.0, but no tag or clear commit (that I can see) that marks the release. https://github.com/yui/yui2 I'm guessing it's https://github.com/yui/yui2/commit/2f98f3692ba447d8b0931b64f645ae1d5acc01ee Do we fork the repo and branch from the 2.9.0 release commit (once we figure it out), or are we going to take all the commits to the YUi2 since the 2.9.0 release?
          Hide
          tfennelly Tom FENNELLY added a comment - - edited

          I forked yui2 into my own repo (for starters): https://github.com/tfennelly/yui2

          I'm trying to find out how they actually built the full release assembly as this is the easiest path to making sure we are getting the right changes over in Jenkins. the yui2 codebase does not have it's own top level build script. Instead, it relies on a a separate "YUI Builder" project, which typically needs to be checked out separately to a folder parallel to the yui code. I actually checked this into a "builder" folder in my fork.

          The problem I'm trying to get to the bottom of is the fact that this Builder just builds a single component (e.g. "buttons"). I'm trying to find out where the higher level release scripts are located - they do an aggregated build + apply copyright, version info etc. I was trying to hack this (build.xml in the root of my fork) but it just results in a ton of diffs. Most of the diffs are OK (missing copyrights etc) but I'd like to get rid of them by building it properly if I can. Then I can see the real differences.

          Show
          tfennelly Tom FENNELLY added a comment - - edited I forked yui2 into my own repo (for starters): https://github.com/tfennelly/yui2 I'm trying to find out how they actually built the full release assembly as this is the easiest path to making sure we are getting the right changes over in Jenkins. the yui2 codebase does not have it's own top level build script. Instead, it relies on a a separate "YUI Builder" project, which typically needs to be checked out separately to a folder parallel to the yui code. I actually checked this into a "builder" folder in my fork. The problem I'm trying to get to the bottom of is the fact that this Builder just builds a single component (e.g. "buttons"). I'm trying to find out where the higher level release scripts are located - they do an aggregated build + apply copyright, version info etc. I was trying to hack this (build.xml in the root of my fork) but it just results in a ton of diffs. Most of the diffs are OK (missing copyrights etc) but I'd like to get rid of them by building it properly if I can. Then I can see the real differences.
          Hide
          tfennelly Tom FENNELLY added a comment -

          Here's the google group post I made trying to get this info: https://groups.google.com/forum/#!topic/yui-deprecated/3dfWrEoYOlI

          Show
          tfennelly Tom FENNELLY added a comment - Here's the google group post I made trying to get this info: https://groups.google.com/forum/#!topic/yui-deprecated/3dfWrEoYOlI
          Hide
          tfennelly Tom FENNELLY added a comment -

          I spent more time trying to produce a YUI2 "release" consistent with whatever produced the 2.9.0 release. Still lots of little picky diffs. Will wait and see if I can get someone from the YUI community to point me to where the YUI2 release scripts are.

          Show
          tfennelly Tom FENNELLY added a comment - I spent more time trying to produce a YUI2 "release" consistent with whatever produced the 2.9.0 release. Still lots of little picky diffs. Will wait and see if I can get someone from the YUI community to point me to where the YUI2 release scripts are.

            People

            • Assignee:
              Unassigned
              Reporter:
              kohsuke Kohsuke Kawaguchi
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: