Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23733

Error in saving Jenkins system configuration due to empty Docker REST URL

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Hello,
      I am trying to save Jenkins system configuration (after changing for example CIFS share or something not related to Docker build step) and getting the message "Docker REST URL cannot be empty".
      Current version of docker-build step is 1.6.

      I believe the URL should be validated only in case of testing connection towards the provided Docker REST URL.
      This type of plugin's implementation prevents any other changes in Jenkins system configuration.

        Attachments

          Activity

          Hide
          vjuranek vjuranek added a comment -

          I agree plugin shouldn't disallow you to make and save any changes, I'll remove this check. But still curious what is the use case for empty Docker URL - as the plugin uses only REST API, IMHO you should either setup Docker URL to be able to use it or you don't need this plugin, as it won't work anyway

          Show
          vjuranek vjuranek added a comment - I agree plugin shouldn't disallow you to make and save any changes, I'll remove this check. But still curious what is the use case for empty Docker URL - as the plugin uses only REST API, IMHO you should either setup Docker URL to be able to use it or you don't need this plugin, as it won't work anyway
          Hide
          jkrizanic Jurica Krizanic added a comment -

          Probably some of my colleagues installed the plugin in order to use Docker, but hasn't set it up yet.

          I've disabled the plugin until Docker and URL are set up, and I am able to save the Jenkins system configuration.

          Still, it shouldn't prevent the user from saving the configuration, as you agreed.

          Thank you for the your answer.

          Show
          jkrizanic Jurica Krizanic added a comment - Probably some of my colleagues installed the plugin in order to use Docker, but hasn't set it up yet. I've disabled the plugin until Docker and URL are set up, and I am able to save the Jenkins system configuration. Still, it shouldn't prevent the user from saving the configuration, as you agreed. Thank you for the your answer.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java
          http://jenkins-ci.org/commit/docker-build-step-plugin/a8b40740b6729682cf765b5e4209cfda2cafb144
          Log:
          [FIXED JENKINS-23733] Allow user to save global config even if Docker URL is empty

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java http://jenkins-ci.org/commit/docker-build-step-plugin/a8b40740b6729682cf765b5e4209cfda2cafb144 Log: [FIXED JENKINS-23733] Allow user to save global config even if Docker URL is empty

            People

            • Assignee:
              vjuranek vjuranek
              Reporter:
              jkrizanic Jurica Krizanic
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: