Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23896

PATCH: CommandInterpreter.join(...) doesn't have access to the Build object

    Details

    • Similar Issues:

      Description

      core/src/main/java/hudson/tasks/CommandInterpreter.java defines a join(Proc p) method that's supposed to be able to set the result to Result.UNSTABLE.

      However, it has no access to the build object to call setResult(...)

      It's an extension point, so while it's not used in-tree it isn't clear if there might be out-of-tree code using it. As such just replacing it with a version that takes more parameters may not be wise.

      I think it's necessary to add a member variable to track the build and a protected accessor; that way the same call interface can be retained. Patch pending.

        Attachments

          Issue Links

            Activity

            ringerc Craig Ringer created issue -
            ringerc Craig Ringer made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-23786 [ JENKINS-23786 ]
            ringerc Craig Ringer made changes -
            Summary CommandInterpreter.join(...) doesn't have access to the Build object PATCH: CommandInterpreter.join(...) doesn't have access to the Build object
            Labels build core patch unstable
            ringerc Craig Ringer made changes -
            Labels build core patch unstable build core patch pull_request unstable
            ringerc Craig Ringer made changes -
            Link This issue is related to JENKINS-23786 [ JENKINS-23786 ]
            ringerc Craig Ringer made changes -
            Link This issue is blocking JENKINS-23786 [ JENKINS-23786 ]
            ringerc Craig Ringer made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ringerc Craig Ringer made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 156761 ] JNJira + In-Review [ 179381 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                ringerc Craig Ringer
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: