Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24014

Jenkins wrongly(?) warns that "reverse proxy set up is broken" when using autorefresh link.

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      Jenkins 1.572 (not under any form of reverse proxy, simply set up with the installer, not using tomcat/apache/..), firefox 29.0
    • Similar Issues:

      Description

      When I go to /manage, there is no warning. When I click "ENABLE AUTO REFRESH" (or "disable .." if it was on already), the page suddenly shows a big red warning "It appears that your reverse proxy set up is broken."

      I haven't set up any reverse proxy, so this seems wrong. I think Jenkins is confused by the parameter in the url formed: /manage?auto_refresh=false. Using the network trace in firefox shows the response header's location is set to:

      http://XXX:8080/administrativeMonitor/hudson.diagnosis.ReverseProxySetupMonitor/testForReverseProxySetup/http%3A%2F%2FXXX%3A8080%2Fmanage%3Fauto_refresh=false/

      for a request to:

      http://XXX:8080/administrativeMonitor/hudson.diagnosis.ReverseProxySetupMonitor/test

      which had a referrer of

      http://XXX:8080/manage?auto_refresh=false

      (I cannot determine from the description if JENKINS-23280 has the same cause, if so, it wasn't detected or described there.)

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -

            This is what's expected
            https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java#L75

            But the parameter passed to the method contains the query string, resulting in a mismatch.

            Show
            danielbeck Daniel Beck added a comment - This is what's expected https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java#L75 But the parameter passed to the method contains the query string, resulting in a mismatch.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java
            http://jenkins-ci.org/commit/jenkins/97366bffe3a7235f8bcd9dfdd30412854ea8308e
            Log:
            [FIXED JENKINS-24014] Make reverse proxy check tolerate ?auto_refresh

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java http://jenkins-ci.org/commit/jenkins/97366bffe3a7235f8bcd9dfdd30412854ea8308e Log: [FIXED JENKINS-24014] Make reverse proxy check tolerate ?auto_refresh
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java
            http://jenkins-ci.org/commit/jenkins/4b6a8dde7d4b9f09d3a8119ea4c1f15142f259bf
            Log:
            Merge pull request #1373 from daniel-beck/JENKINS-24014

            [FIXED JENKINS-24014] Make reverse proxy check tolerate ?auto_refresh

            Compare: https://github.com/jenkinsci/jenkins/compare/fe3b33a16e85...4b6a8dde7d4b

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java http://jenkins-ci.org/commit/jenkins/4b6a8dde7d4b9f09d3a8119ea4c1f15142f259bf Log: Merge pull request #1373 from daniel-beck/ JENKINS-24014 [FIXED JENKINS-24014] Make reverse proxy check tolerate ?auto_refresh Compare: https://github.com/jenkinsci/jenkins/compare/fe3b33a16e85...4b6a8dde7d4b
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3651
            [FIXED JENKINS-24014] Make reverse proxy check tolerate ?auto_refresh (Revision 97366bffe3a7235f8bcd9dfdd30412854ea8308e)

            Result = SUCCESS
            daniel-beck : 97366bffe3a7235f8bcd9dfdd30412854ea8308e
            Files :

            • core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3651 [FIXED JENKINS-24014] Make reverse proxy check tolerate ?auto_refresh (Revision 97366bffe3a7235f8bcd9dfdd30412854ea8308e) Result = SUCCESS daniel-beck : 97366bffe3a7235f8bcd9dfdd30412854ea8308e Files : core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java

              People

              • Assignee:
                danielbeck Daniel Beck
                Reporter:
                legolas Arnt Witteveen
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: