Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24316

Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

    Details

    • Similar Issues:

      Description

      Since the update to 1.576, the icons generated by plugins on the left navigation bar no longer display. This is throughout the whole userinterface: homepage, job page,... (everywhere).

      The reason is that the image src URL is generated as "//plugin/...", which makes the browser resolve "plugin" as hostname. URLs starting with "//" mean "same protocol".

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/4c0cfe40c9ebbea81bf2b8a6931cda3513be1bfe
            Log:
            Noting RC merge of JENKINS-24316, JENKINS-24317

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: changelog.html http://jenkins-ci.org/commit/jenkins/4c0cfe40c9ebbea81bf2b8a6931cda3513be1bfe Log: Noting RC merge of JENKINS-24316 , JENKINS-24317
            Hide
            danielbeck Daniel Beck added a comment -

            The fix will be in 1.577, scheduled to be released this weekend or so.

            Show
            danielbeck Daniel Beck added a comment - The fix will be in 1.577, scheduled to be released this weekend or so.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3646
            [FIXED JENKINS-24316] Fixed unknown task icon src path construction (Revision 830a5e7f618a53a4ff3d1cad1127efc5fcc47601)
            Readd static resource path for task icons JENKINS-24316 (Revision 5b805fa16e240e3657a7f263eeef11281a393efa)

            Result = SUCCESS
            Jesse Glick : 830a5e7f618a53a4ff3d1cad1127efc5fcc47601
            Files :

            • test/src/test/resources/lib/layout/IconTest/03_testTask.jelly
            • test/src/test/java/lib/layout/IconTest.java
            • core/src/main/resources/lib/layout/task.jelly
            • test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly

            Jesse Glick : 5b805fa16e240e3657a7f263eeef11281a393efa
            Files :

            • core/src/main/resources/lib/layout/task.jelly
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3646 [FIXED JENKINS-24316] Fixed unknown task icon src path construction (Revision 830a5e7f618a53a4ff3d1cad1127efc5fcc47601) Readd static resource path for task icons JENKINS-24316 (Revision 5b805fa16e240e3657a7f263eeef11281a393efa) Result = SUCCESS Jesse Glick : 830a5e7f618a53a4ff3d1cad1127efc5fcc47601 Files : test/src/test/resources/lib/layout/IconTest/03_testTask.jelly test/src/test/java/lib/layout/IconTest.java core/src/main/resources/lib/layout/task.jelly test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly Jesse Glick : 5b805fa16e240e3657a7f263eeef11281a393efa Files : core/src/main/resources/lib/layout/task.jelly
            Hide
            dshvedchenko Denis Shvedchenko added a comment -

            Hi, I've found that some plugin ( config-file-provider ) , starts suffering from similar trouble ( rendering icons by \jenkins\core\src\main\resources\lib\layout\layout.jelly in main-panel-content ). if you can classify it for jenkins issue , or plugin issue, please, it would be nice

            Show
            dshvedchenko Denis Shvedchenko added a comment - Hi, I've found that some plugin ( config-file-provider ) , starts suffering from similar trouble ( rendering icons by \jenkins\core\src\main\resources\lib\layout\layout.jelly in main-panel-content ). if you can classify it for jenkins issue , or plugin issue, please, it would be nice
            Hide
            danielbeck Daniel Beck added a comment -

            Denis Shvedchenko: If this occurs in 1.576, we don't care since there was a fix since. If it occurs in 1.577, please file a new issue against core and the plugin it occurs in as components, we'll sort it out. Make sure to use the label "user-experience".

            Show
            danielbeck Daniel Beck added a comment - Denis Shvedchenko : If this occurs in 1.576, we don't care since there was a fix since. If it occurs in 1.577, please file a new issue against core and the plugin it occurs in as components, we'll sort it out. Make sure to use the label "user-experience".

              People

              • Assignee:
                tfennelly Tom FENNELLY
                Reporter:
                thetaphi Uwe Schindler
              • Votes:
                12 Vote for this issue
                Watchers:
                14 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: