Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24341

Subversion disables projects, which do not support the disabling

    Details

    • Similar Issues:

      Description

      Subversion Plugin disables projects when repositories are missing, etc.
      The plugin does not call AbstractProject::supportsMakeDisabled(). Due to JENKINS-24340, it leads to the disabling of Matrix Configurations (JENKINS-19179) and other such projects.

        Attachments

          Issue Links

            Activity

            Show
            oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/subversion-plugin/pull/92
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The issue can be easily reproduced on Subversion Plugin.
            It makes sense to make it lts-candidate

            Show
            oleg_nenashev Oleg Nenashev added a comment - The issue can be easily reproduced on Subversion Plugin. It makes sense to make it lts-candidate
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/AbstractProject.java
            http://jenkins-ci.org/commit/jenkins/a78f1d3246cfdbee96820d5629dbb8676a3ca19a
            Log:
            [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false

            This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check.
            As an example, Subversion plugin behaves in such way (JENKINS-24341)

            Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/a78f1d3246cfdbee96820d5629dbb8676a3ca19a Log: [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check. As an example, Subversion plugin behaves in such way ( JENKINS-24341 ) Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/hudson/scm/SubversionSCM.java
            src/main/resources/hudson/scm/subversion/Messages.properties
            http://jenkins-ci.org/commit/subversion-plugin/9ea9dd80de5e01e713f9bfef6c0080f667a72d6d
            Log:
            [FIXED JENKINS-24341] - Check if the project can be disabled before the disabling

            The change call the AbstractProject::supportsMakeDisabled() before calling AbstractProject::makeDisabled()

            Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/scm/SubversionSCM.java src/main/resources/hudson/scm/subversion/Messages.properties http://jenkins-ci.org/commit/subversion-plugin/9ea9dd80de5e01e713f9bfef6c0080f667a72d6d Log: [FIXED JENKINS-24341] - Check if the project can be disabled before the disabling The change call the AbstractProject::supportsMakeDisabled() before calling AbstractProject::makeDisabled() Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/hudson/scm/SubversionSCM.java
            src/main/resources/hudson/scm/subversion/Messages.properties
            http://jenkins-ci.org/commit/subversion-plugin/cb444c3a7ca376a44c382b3c3445de3c89152574
            Log:
            Merge pull request #92 from synopsys-arc-oss/JENKINS-24341

            [FIXED JENKINS-24341] - Check if the project can be disabled before the disabling

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/d6b9e33e82b3...cb444c3a7ca3

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/scm/SubversionSCM.java src/main/resources/hudson/scm/subversion/Messages.properties http://jenkins-ci.org/commit/subversion-plugin/cb444c3a7ca376a44c382b3c3445de3c89152574 Log: Merge pull request #92 from synopsys-arc-oss/ JENKINS-24341 [FIXED JENKINS-24341] - Check if the project can be disabled before the disabling Compare: https://github.com/jenkinsci/subversion-plugin/compare/d6b9e33e82b3...cb444c3a7ca3
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/AbstractProject.java
            http://jenkins-ci.org/commit/jenkins/1b0d8fb63aa98a666f656a60c4c6802c6d023dba
            Log:
            [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false

            This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check.
            As an example, Subversion plugin behaves in such way (JENKINS-24341)

            Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
            (cherry picked from commit a78f1d3246cfdbee96820d5629dbb8676a3ca19a)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/1b0d8fb63aa98a666f656a60c4c6802c6d023dba Log: [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check. As an example, Subversion plugin behaves in such way ( JENKINS-24341 ) Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com> (cherry picked from commit a78f1d3246cfdbee96820d5629dbb8676a3ca19a)

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: