Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24358

Deadlock in OldDataMonitor

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Thread #1 BLOCKED on hudson.model.RunMap owned by Thread #2
          at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:648)
          -  blocked on hudson.model.RunMap
          at jenkins.model.lazy.AbstractLazyLoadRunMap.search(AbstractLazyLoadRunMap.java:381)
          at jenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(AbstractLazyLoadRunMap.java:546)
          at hudson.model.AbstractProject.getBuildByNumber(AbstractProject.java:1073)
          at hudson.model.AbstractProject.getBuildByNumber(AbstractProject.java:156)
          at hudson.model.Run.fromExternalizableId(Run.java:2231)
          at hudson.diagnosis.OldDataMonitor$RunSaveableReference.get(OldDataMonitor.java:361)
          at hudson.diagnosis.OldDataMonitor.getData(OldDataMonitor.java:90)
          ...
      
      Thread #2 BLOCKED on hudson.diagnosis.OldDataMonitor owned by Thread #1
          at hudson.diagnosis.OldDataMonitor.report(OldDataMonitor.java:200)
          -  blocked on hudson.diagnosis.OldDataMonitor
          at hudson.util.RobustReflectionConverter.doUnmarshal(RobustReflectionConverter.java:327)
          at ...(loading a Run)...
      

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Probably introduced by fix of JENKINS-19544.

            Show
            jglick Jesse Glick added a comment - Probably introduced by fix of JENKINS-19544 .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            http://jenkins-ci.org/commit/jenkins/5fea6cb52c8a5f6323f1744ad20dbaa66d92e6ba
            Log:
            [FIXED JENKINS-24358] RunSaveableReference.get can acquire locks, so avoid calling it while holding a lock on ourselves.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/diagnosis/OldDataMonitor.java http://jenkins-ci.org/commit/jenkins/5fea6cb52c8a5f6323f1744ad20dbaa66d92e6ba Log: [FIXED JENKINS-24358] RunSaveableReference.get can acquire locks, so avoid calling it while holding a lock on ourselves.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3636
            [FIXED JENKINS-24358] RunSaveableReference.get can acquire locks, so avoid calling it while holding a lock on ourselves. (Revision 5fea6cb52c8a5f6323f1744ad20dbaa66d92e6ba)

            Result = SUCCESS
            Jesse Glick : 5fea6cb52c8a5f6323f1744ad20dbaa66d92e6ba
            Files :

            • changelog.html
            • core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3636 [FIXED JENKINS-24358] RunSaveableReference.get can acquire locks, so avoid calling it while holding a lock on ourselves. (Revision 5fea6cb52c8a5f6323f1744ad20dbaa66d92e6ba) Result = SUCCESS Jesse Glick : 5fea6cb52c8a5f6323f1744ad20dbaa66d92e6ba Files : changelog.html core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            Hide
            jglick Jesse Glick added a comment -

            Probably always possible, but gets triggered a lot by Support Core plugin, which asks for getData.

            Show
            jglick Jesse Glick added a comment - Probably always possible, but gets triggered a lot by Support Core plugin, which asks for getData .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/com/cloudbees/jenkins/support/impl/AdministrativeMonitors.java
            http://jenkins-ci.org/commit/support-core-plugin/a116037fe3855d81be347c9835a7c48043d5786b
            Log:
            Trying to avoid triggering JENKINS-24358 deadlock.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/com/cloudbees/jenkins/support/impl/AdministrativeMonitors.java http://jenkins-ci.org/commit/support-core-plugin/a116037fe3855d81be347c9835a7c48043d5786b Log: Trying to avoid triggering JENKINS-24358 deadlock.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            http://jenkins-ci.org/commit/jenkins/efbdd4d4d9f6f997ef97d7e828a7320f59fbe33a
            Log:
            [FIXED JENKINS-24358] RunSaveableReference.get can acquire locks, so avoid calling it while holding a lock on ourselves.
            (cherry picked from commit 5fea6cb52c8a5f6323f1744ad20dbaa66d92e6ba)

            Conflicts:
            changelog.html

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/diagnosis/OldDataMonitor.java http://jenkins-ci.org/commit/jenkins/efbdd4d4d9f6f997ef97d7e828a7320f59fbe33a Log: [FIXED JENKINS-24358] RunSaveableReference.get can acquire locks, so avoid calling it while holding a lock on ourselves. (cherry picked from commit 5fea6cb52c8a5f6323f1744ad20dbaa66d92e6ba) Conflicts: changelog.html

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: