Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24483

RepositoryBrowser.getChangeSetLink exceptions from Jelly pollute log

    Details

    • Similar Issues:

      Description

      Your Jenkins log can fill up with long stack traces like

      h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: browser.getChangeSetLink(cs) in /jenkins/job/.../1234/. Reason: java.net.MalformedURLException: no protocol: 
      java.net.MalformedURLException: no protocol: 
      	at java.net.URL.<init>(URL.java:585)
      	at java.net.URL.<init>(URL.java:482)
      	at java.net.URL.<init>(URL.java:431)
      	at hudson.plugins.git.browser.GitRepositoryBrowser.getUrl(GitRepositoryBrowser.java:47)
      	at hudson.plugins.git.browser.GithubWeb.getChangeSetLink(GithubWeb.java:40)
      	at ...
      

      when this is a harmless condition: just an unconfigured git repository browser base URL.

      Probably RepositoryBrowser should get a new method that calls getChangeSetLink but logs exceptions at FINE and returns null, and then Jelly views (both in core and plugins) should be updated to use it. (Falling back to displaying an unlinked changeset, just as if getChangeSetLink returned null.)

        Attachments

          Activity

          jglick Jesse Glick created issue -
          nonlux Oleg Zoo made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          nonlux Oleg Zoo made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 157464 ] JNJira + In-Review [ 179589 ]
          markewaite Mark Waite made changes -
          Description Your Jenkins log can fill up with long stack traces like

          {code:none}
          h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: browser.getChangeSetLink(cs) in /jenkins/job/.../1234/. Reason: java.net.MalformedURLException: no protocol:
          java.net.MalformedURLException: no protocol:
          at java.net.URL.<init>(URL.java:585)
          at java.net.URL.<init>(URL.java:482)
          at java.net.URL.<init>(URL.java:431)
          at hudson.plugins.git.browser.GitRepositoryBrowser.getUrl(GitRepositoryBrowser.java:47)
          at hudson.plugins.git.browser.GithubWeb.getChangeSetLink(GithubWeb.java:40)
          at ...
          {code}

          when this is a harmless condition: just an unconfigured base URL.

          Probably {{RepositoryBrowser}} should get a new method that calls {{getChangeSetLink}} but logs exceptions at {{FINE}} and returns null, and then Jelly views (both in core and plugins) should be updated to use it. (Falling back to displaying an unlinked changeset, just as if {{getChangeSetLink}} returned null.)
          Your Jenkins log can fill up with long stack traces like

          {code:none}
          h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: browser.getChangeSetLink(cs) in /jenkins/job/.../1234/. Reason: java.net.MalformedURLException: no protocol:
          java.net.MalformedURLException: no protocol:
          at java.net.URL.<init>(URL.java:585)
          at java.net.URL.<init>(URL.java:482)
          at java.net.URL.<init>(URL.java:431)
          at hudson.plugins.git.browser.GitRepositoryBrowser.getUrl(GitRepositoryBrowser.java:47)
          at hudson.plugins.git.browser.GithubWeb.getChangeSetLink(GithubWeb.java:40)
          at ...
          {code}

          when this is a harmless condition: just an unconfigured git repository browser base URL.

          Probably {{RepositoryBrowser}} should get a new method that calls {{getChangeSetLink}} but logs exceptions at {{FINE}} and returns null, and then Jelly views (both in core and plugins) should be updated to use it. (Falling back to displaying an unlinked changeset, just as if {{getChangeSetLink}} returned null.)
          ndeloof Nicolas De Loof made changes -
          Assignee Nicolas De Loof [ ndeloof ]

            People

            • Assignee:
              Unassigned
              Reporter:
              jglick Jesse Glick
            • Votes:
              10 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated: