Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2476

Incorrect link for module with colon in summary

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: findbugs-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      Incorrect link for module with colon in summary.

      If module name contains colon the module link in the summary will incorrect e.g.
      for module "Flexess: server model" it will be "module.flexess:%20server%20model/".

        Attachments

          Activity

          Hide
          drulli Ulli Hafner added a comment -

          The same problem occurs when using a slash or backslash in the name. I'll
          replace the link names with hash codes (as for file links).

          Show
          drulli Ulli Hafner added a comment - The same problem occurs when using a slash or backslash in the name. I'll replace the link names with hash codes (as for file links).
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : drulli
          Path:
          trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/util/DetailBuilder.java
          trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/util/model/AnnotationContainer.java
          trunk/hudson/plugins/checkstyle/src/main/resources/tabview/modules.jelly
          trunk/hudson/plugins/checkstyle/src/main/resources/tabview/packages.jelly
          trunk/hudson/plugins/checkstyle/src/test/java/hudson/plugins/checkstyle/util/AbstractAnnotationsBuildResultTest.java
          trunk/hudson/plugins/findbugs/src/main/java/hudson/plugins/findbugs/util/DetailBuilder.java
          trunk/hudson/plugins/findbugs/src/main/java/hudson/plugins/findbugs/util/model/AnnotationContainer.java
          trunk/hudson/plugins/findbugs/src/main/resources/tabview/modules.jelly
          trunk/hudson/plugins/findbugs/src/main/resources/tabview/packages.jelly
          trunk/hudson/plugins/findbugs/src/test/java/hudson/plugins/findbugs/util/AbstractAnnotationsBuildResultTest.java
          trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/util/DetailBuilder.java
          trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/util/model/AnnotationContainer.java
          trunk/hudson/plugins/pmd/src/main/resources/tabview/modules.jelly
          trunk/hudson/plugins/pmd/src/main/resources/tabview/packages.jelly
          trunk/hudson/plugins/pmd/src/test/java/hudson/plugins/pmd/util/AbstractAnnotationsBuildResultTest.java
          trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/TaskDetailBuilder.java
          trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/util/DetailBuilder.java
          trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/util/model/AnnotationContainer.java
          trunk/hudson/plugins/tasks/src/main/resources/tabview/modules.jelly
          trunk/hudson/plugins/tasks/src/main/resources/tabview/packages.jelly
          trunk/hudson/plugins/tasks/src/test/java/hudson/plugins/tasks/util/AbstractAnnotationsBuildResultTest.java
          trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/util/DetailBuilder.java
          trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/util/model/AnnotationContainer.java
          trunk/hudson/plugins/warnings/src/main/resources/tabview/modules.jelly
          trunk/hudson/plugins/warnings/src/main/resources/tabview/packages.jelly
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/util/AbstractAnnotationsBuildResultTest.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=12599
          Log:
          [FIXED JENKINS-2476] Generate hyperlink names using the hash code of module or package names.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : drulli Path: trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/util/DetailBuilder.java trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/util/model/AnnotationContainer.java trunk/hudson/plugins/checkstyle/src/main/resources/tabview/modules.jelly trunk/hudson/plugins/checkstyle/src/main/resources/tabview/packages.jelly trunk/hudson/plugins/checkstyle/src/test/java/hudson/plugins/checkstyle/util/AbstractAnnotationsBuildResultTest.java trunk/hudson/plugins/findbugs/src/main/java/hudson/plugins/findbugs/util/DetailBuilder.java trunk/hudson/plugins/findbugs/src/main/java/hudson/plugins/findbugs/util/model/AnnotationContainer.java trunk/hudson/plugins/findbugs/src/main/resources/tabview/modules.jelly trunk/hudson/plugins/findbugs/src/main/resources/tabview/packages.jelly trunk/hudson/plugins/findbugs/src/test/java/hudson/plugins/findbugs/util/AbstractAnnotationsBuildResultTest.java trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/util/DetailBuilder.java trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/util/model/AnnotationContainer.java trunk/hudson/plugins/pmd/src/main/resources/tabview/modules.jelly trunk/hudson/plugins/pmd/src/main/resources/tabview/packages.jelly trunk/hudson/plugins/pmd/src/test/java/hudson/plugins/pmd/util/AbstractAnnotationsBuildResultTest.java trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/TaskDetailBuilder.java trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/util/DetailBuilder.java trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/util/model/AnnotationContainer.java trunk/hudson/plugins/tasks/src/main/resources/tabview/modules.jelly trunk/hudson/plugins/tasks/src/main/resources/tabview/packages.jelly trunk/hudson/plugins/tasks/src/test/java/hudson/plugins/tasks/util/AbstractAnnotationsBuildResultTest.java trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/util/DetailBuilder.java trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/util/model/AnnotationContainer.java trunk/hudson/plugins/warnings/src/main/resources/tabview/modules.jelly trunk/hudson/plugins/warnings/src/main/resources/tabview/packages.jelly trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/util/AbstractAnnotationsBuildResultTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=12599 Log: [FIXED JENKINS-2476] Generate hyperlink names using the hash code of module or package names.
          Hide
          drulli Ulli Hafner added a comment -

          The same fix should be used for categories and types too, since we can't enforce
          valid names.

          Show
          drulli Ulli Hafner added a comment - The same fix should be used for categories and types too, since we can't enforce valid names.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : drulli
          Path:
          trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/util/DetailBuilder.java
          trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/util/model/AnnotationContainer.java
          trunk/hudson/plugins/checkstyle/src/main/resources/tabview/categories.jelly
          trunk/hudson/plugins/checkstyle/src/main/resources/tabview/types.jelly
          trunk/hudson/plugins/findbugs/src/main/java/hudson/plugins/findbugs/util/DetailBuilder.java
          trunk/hudson/plugins/findbugs/src/main/java/hudson/plugins/findbugs/util/model/AnnotationContainer.java
          trunk/hudson/plugins/findbugs/src/main/resources/tabview/categories.jelly
          trunk/hudson/plugins/findbugs/src/main/resources/tabview/types.jelly
          trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/util/DetailBuilder.java
          trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/util/model/AnnotationContainer.java
          trunk/hudson/plugins/pmd/src/main/resources/tabview/categories.jelly
          trunk/hudson/plugins/pmd/src/main/resources/tabview/types.jelly
          trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/util/DetailBuilder.java
          trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/util/model/AnnotationContainer.java
          trunk/hudson/plugins/tasks/src/main/resources/tabview/categories.jelly
          trunk/hudson/plugins/tasks/src/main/resources/tabview/types.jelly
          trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/util/DetailBuilder.java
          trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/util/model/AnnotationContainer.java
          trunk/hudson/plugins/warnings/src/main/resources/tabview/categories.jelly
          trunk/hudson/plugins/warnings/src/main/resources/tabview/types.jelly
          http://fisheye4.cenqua.com/changelog/hudson/?cs=13990
          Log:
          [FIXED JENKINS-2476] Generate hyperlink names using the hash code of type or category names.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : drulli Path: trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/util/DetailBuilder.java trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/util/model/AnnotationContainer.java trunk/hudson/plugins/checkstyle/src/main/resources/tabview/categories.jelly trunk/hudson/plugins/checkstyle/src/main/resources/tabview/types.jelly trunk/hudson/plugins/findbugs/src/main/java/hudson/plugins/findbugs/util/DetailBuilder.java trunk/hudson/plugins/findbugs/src/main/java/hudson/plugins/findbugs/util/model/AnnotationContainer.java trunk/hudson/plugins/findbugs/src/main/resources/tabview/categories.jelly trunk/hudson/plugins/findbugs/src/main/resources/tabview/types.jelly trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/util/DetailBuilder.java trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/util/model/AnnotationContainer.java trunk/hudson/plugins/pmd/src/main/resources/tabview/categories.jelly trunk/hudson/plugins/pmd/src/main/resources/tabview/types.jelly trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/util/DetailBuilder.java trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/util/model/AnnotationContainer.java trunk/hudson/plugins/tasks/src/main/resources/tabview/categories.jelly trunk/hudson/plugins/tasks/src/main/resources/tabview/types.jelly trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/util/DetailBuilder.java trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/util/model/AnnotationContainer.java trunk/hudson/plugins/warnings/src/main/resources/tabview/categories.jelly trunk/hudson/plugins/warnings/src/main/resources/tabview/types.jelly http://fisheye4.cenqua.com/changelog/hudson/?cs=13990 Log: [FIXED JENKINS-2476] Generate hyperlink names using the hash code of type or category names.

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              foal foal
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: