Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24802

notifyCommit don't trigger a build if two svn repositories have same url start

    Details

    • Similar Issues:

      Description

      In SubversionRepositoryStatus 's onNotify method, UUID cache checks that UUID is in cache using the String 's startsWith method for a repo.
      But when having of two jobs with these svn repos/modules configured :
      https://svn.company.com/repo-client
      https://svn.company.com/repo-client-project-one

      The UUID check for https://svn.company.com/repo-client-project-one will use the UUID of https://svn.company.com/repo-client because https://svn.company.com/repo-client-project-one starts with https://svn.company.com/repo-client.

      This bug was introduced by myself when optimzing (e.g. caching) repositories URLs <-> UUIDs.

      @see https://github.com/jenkinsci/subversion-plugin/blob/subversion-2.3/src/main/java/hudson/scm/SubversionRepositoryStatus.java

        Attachments

          Issue Links

            Activity

            Hide
            kenji Richard Bergoin added a comment -

            The issue is still present if an external without credentials with same "url start" is checked before the "main repo" : no build triggered.

            Found why : a try/catch is above the loop checking, instead of inside. Reproduced, fixed, will PR in next minutes

            Show
            kenji Richard Bergoin added a comment - The issue is still present if an external without credentials with same "url start" is checked before the "main repo" : no build triggered. Found why : a try/catch is above the loop checking, instead of inside. Reproduced, fixed, will PR in next minutes
            Show
            kenji Richard Bergoin added a comment - PR sent :  https://github.com/jenkinsci/subversion-plugin/pull/199
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: kenji21
            Path:
            src/main/java/hudson/scm/SubversionRepositoryStatus.java
            http://jenkins-ci.org/commit/subversion-plugin/6d4f7dd404ff15f4aae16d93c43c56617e4ee862
            Log:
            JENKINS-24802 notifyCommit don't trigger a build

            Moved try/catch inside the loop to have next ModuleLocation checked if
            a SVNCancelExcpetion is raised
            Updated error message helping to diagnose which job(s) causes
            SVNCancelException(s)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kenji21 Path: src/main/java/hudson/scm/SubversionRepositoryStatus.java http://jenkins-ci.org/commit/subversion-plugin/6d4f7dd404ff15f4aae16d93c43c56617e4ee862 Log: JENKINS-24802 notifyCommit don't trigger a build Moved try/catch inside the loop to have next ModuleLocation checked if a SVNCancelExcpetion is raised Updated error message helping to diagnose which job(s) causes SVNCancelException(s)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/hudson/scm/SubversionRepositoryStatus.java
            http://jenkins-ci.org/commit/subversion-plugin/50b30fa094b3cf0cffdb8c0840287abbe08360ae
            Log:
            Merge pull request #199 from kenji21/master

            JENKINS-24802 notifyCommit don't trigger a build

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/c486ec882453...50b30fa094b3

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/scm/SubversionRepositoryStatus.java http://jenkins-ci.org/commit/subversion-plugin/50b30fa094b3cf0cffdb8c0840287abbe08360ae Log: Merge pull request #199 from kenji21/master JENKINS-24802 notifyCommit don't trigger a build Compare: https://github.com/jenkinsci/subversion-plugin/compare/c486ec882453...50b30fa094b3
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            It has been released in Subversion Plugin 2.10

            Show
            oleg_nenashev Oleg Nenashev added a comment - It has been released in Subversion Plugin 2.10

              People

              • Assignee:
                kenji Richard Bergoin
                Reporter:
                kenji Richard Bergoin
              • Votes:
                6 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: