Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24940

New Warnings link in Static Analysis results shows all warnings

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: analysis-core-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.581
      analysis-core 1.59
      analysis-collector 1.41
    • Similar Issues:

      Description

      In my views for static analysis results, I get links for 'New Warnings', yet clicking on these links brings up a view with all warnings not just the filtered new warnings.

      This occurs for both the collector view and individual PMD, Checkstyle, etc views.

      These urls for example, show the same thing:
      https://jenkins.../job/analysis/826/analysisResult/new/
      https://jenkins.../job/analysis/826/analysisResult/

        Attachments

        1. allWarnings.jpg
          allWarnings.jpg
          55 kB
        2. build_history.jpg
          build_history.jpg
          12 kB
        3. newWarnings.jpg
          newWarnings.jpg
          47 kB

          Activity

          Hide
          drulli Ulli Hafner added a comment -

          I see. I don't think that this information should be updated after a build has been finalized, this would get too complicated. The best way would be to still show 3 new warnings. Also shifting/deleting the reference build would be too complicated, too.

          Show
          drulli Ulli Hafner added a comment - I see. I don't think that this information should be updated after a build has been finalized, this would get too complicated. The best way would be to still show 3 new warnings. Also shifting/deleting the reference build would be too complicated, too.
          Hide
          arothian Kevin Formsma added a comment -

          I think that it makes sense to keep the new warnings the same if a build is deleted and not recomputing it with the new parent build (if any exists). Just because build 5 was deleted doesn't mean that build 6 introduced more warnings. It still only introduced 3.

          Show
          arothian Kevin Formsma added a comment - I think that it makes sense to keep the new warnings the same if a build is deleted and not recomputing it with the new parent build (if any exists). Just because build 5 was deleted doesn't mean that build 6 introduced more warnings. It still only introduced 3.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          analysis-core
          checkstyle
          http://jenkins-ci.org/commit/analysis-suite-plugin/283578dfccd10b7ee5cbf9c4473c37349b1bff6a
          Log:
          JENKINS-24940 Persist the build number that introduced a new warning.

          • Removed loading of reference build when computing new or fixed warnings.
          • Added a new property for each warning that stores the build number this warning has been introduced.
          • Changed serialization so that all fixed warnings are stored in a separate file.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: analysis-core checkstyle http://jenkins-ci.org/commit/analysis-suite-plugin/283578dfccd10b7ee5cbf9c4473c37349b1bff6a Log: JENKINS-24940 Persist the build number that introduced a new warning. Removed loading of reference build when computing new or fixed warnings. Added a new property for each warning that stores the build number this warning has been introduced. Changed serialization so that all fixed warnings are stored in a separate file.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/core/BuildResult.java
          src/main/java/hudson/plugins/analysis/util/model/AbstractAnnotation.java
          src/main/java/hudson/plugins/analysis/util/model/FileAnnotation.java
          http://jenkins-ci.org/commit/analysis-core-plugin/c6f6e3e1cd55b87d848a1503abe2a76aef7f777d
          Log:
          JENKINS-24940 Persist the build number that introduced a new warning.

          • Removed loading of reference build when computing new or fixed warnings.
          • Added a new property for each warning that stores the build number this warning has been introduced.
          • Changed serialization so that all fixed warnings are stored in a separate file.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/core/BuildResult.java src/main/java/hudson/plugins/analysis/util/model/AbstractAnnotation.java src/main/java/hudson/plugins/analysis/util/model/FileAnnotation.java http://jenkins-ci.org/commit/analysis-core-plugin/c6f6e3e1cd55b87d848a1503abe2a76aef7f777d Log: JENKINS-24940 Persist the build number that introduced a new warning. Removed loading of reference build when computing new or fixed warnings. Added a new property for each warning that stores the build number this warning has been introduced. Changed serialization so that all fixed warnings are stored in a separate file.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisAction.java
          src/test/java/plugins/AnalysisCollectorPluginTest.java
          src/test/java/plugins/CheckStylePluginTest.java
          src/test/java/plugins/FindBugsPluginTest.java
          src/test/java/plugins/PmdPluginTest.java
          src/test/java/plugins/TaskScannerPluginTest.java
          src/test/java/plugins/WarningsPluginTest.java
          http://jenkins-ci.org/commit/acceptance-test-harness/c8a96001366835afd3d8fa15e4e6ed0dfd611443
          Log:
          JENKINS-24940 Added checking of fixed and new warnings.

          Fixed and new warnings are now checked twice: right after a build
          and after a restart of Jenkins.

          Improved test cases:

          • Added verification of fixed warnings.
          • Use new summary table IDs when checking the cells.
          • Check the overview values as well as the number of elements in the fixed warnings table.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisAction.java src/test/java/plugins/AnalysisCollectorPluginTest.java src/test/java/plugins/CheckStylePluginTest.java src/test/java/plugins/FindBugsPluginTest.java src/test/java/plugins/PmdPluginTest.java src/test/java/plugins/TaskScannerPluginTest.java src/test/java/plugins/WarningsPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/c8a96001366835afd3d8fa15e4e6ed0dfd611443 Log: JENKINS-24940 Added checking of fixed and new warnings. Fixed and new warnings are now checked twice: right after a build and after a restart of Jenkins. Improved test cases: Added verification of fixed warnings. Use new summary table IDs when checking the cells. Check the overview values as well as the number of elements in the fixed warnings table.

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              arothian Kevin Formsma
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: