Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24970

Blank page when reapproving

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Hi, i'm running with Jenkins 1.559 and promoted builds plugin 2.17.
      In a job with a promotion process defined with a manual approval, the first execution of the promotion on a build (by clicking 'approve' button) is successful, but the next ones (by clicking on 'Re-execute promotion' button) return a blank http page, and produces this exception in Jenkins log:

       
      Error while serving http://ci-server/jenkins/job/test_promotion_1/descriptorByName/org.jenkinsci.plugins.ghprb.GhprbTrigger/checkCron
      java.lang.reflect.InvocationTargetException
      	at sun.reflect.GeneratedMethodAccessor1135.invoke(Unknown Source)
      (snip)	
      Caused by: java.lang.NoSuchMethodError: hudson.triggers.TimerTrigger$DescriptorImpl.doCheckSpec(Ljava/lang/String;)Lhudson/util/FormValidation;
      	at org.jenkinsci.plugins.ghprb.GhprbTrigger$DescriptorImpl.doCheckCron(GhprbTrigger.java:349)
      

      The problem is not reproducible when i use an admin user.

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -

            Duplicates JENKINS-22550

            Show
            danielbeck Daniel Beck added a comment - Duplicates JENKINS-22550
            Hide
            maxime_lem Maxime Lemanissier added a comment -

            Hi Daniel,
            Thanks for the link to JENKINS-22550. I have upgraded GHPRB plugin to 1.16-1 and I don't get the NoSuchMethodError anymore, but I still get the blank page when I re-execute a promotion. In my case, a given promotion with manual approval can only be run once on a given build.

            Show
            maxime_lem Maxime Lemanissier added a comment - Hi Daniel, Thanks for the link to JENKINS-22550 . I have upgraded GHPRB plugin to 1.16-1 and I don't get the NoSuchMethodError anymore, but I still get the blank page when I re-execute a promotion. In my case, a given promotion with manual approval can only be run once on a given build.
            Hide
            maxime_lem Maxime Lemanissier added a comment -

            One precision that might be important : this user does not have the 'promote' permission (though he's able to run the promotion using the button 'approve' - button 'force promotion' is not displayed)

            Show
            maxime_lem Maxime Lemanissier added a comment - One precision that might be important : this user does not have the 'promote' permission (though he's able to run the promotion using the button 'approve' - button 'force promotion' is not displayed)
            Hide
            maxime_lem Maxime Lemanissier added a comment -

            The html forms for approving or re-approving are also quite different.
            For first approval, the form is <form name="approve" action="promotionProcess/4-tag-live/promotionCondition/hudson.plugins.promoted_builds.conditions.ManualCondition/approve" method="post">
            For next approvals (which produce blank page), the form is <form name="build" action="4-tag-live/build" method="post">

            Show
            maxime_lem Maxime Lemanissier added a comment - The html forms for approving or re-approving are also quite different. For first approval, the form is <form name="approve" action="promotionProcess/4-tag-live/promotionCondition/hudson.plugins.promoted_builds.conditions.ManualCondition/approve" method="post"> For next approvals (which produce blank page), the form is <form name="build" action="4-tag-live/build" method="post">
            Hide
            maxime_lem Maxime Lemanissier added a comment -

            I made a last test. If I post to http://myCIServer/jenkins/job/test_promotion_1/5/promotion/promotionProcess/tag-live/promotionCondition/hudson.plugins.promoted_builds.conditions.ManualCondition/approve a form with data json={} and Submit=approve, the promotion is run successfully. But if I resend this exact post, I get back http://myCIServer/jenkins/job/test_promotion_1/5/promotion and no further promotion build is run.
            I'm not sure why reapprovals are not using the same mechanism than first approval but that might explain why formers are not working in my case.

            Show
            maxime_lem Maxime Lemanissier added a comment - I made a last test. If I post to http://myCIServer/jenkins/job/test_promotion_1/5/promotion/promotionProcess/tag-live/promotionCondition/hudson.plugins.promoted_builds.conditions.ManualCondition/approve a form with data json={} and Submit=approve, the promotion is run successfully. But if I resend this exact post, I get back http://myCIServer/jenkins/job/test_promotion_1/5/promotion and no further promotion build is run. I'm not sure why reapprovals are not using the same mechanism than first approval but that might explain why formers are not working in my case.
            Hide
            danielbeck Daniel Beck added a comment -

            May be related to a change in core that changed how build/buildWithParameter URLs are handled, if the plugin derives its promotion build type from the affected core base class. Tests using a selection of core versions (1.424.x, 1.447.x, 1.466.x, 1.480.x, 1.509.x, 1.532.x, 1.554.x, 1.565.x) would be helpful in determining whether this worked some time in the past.

            Show
            danielbeck Daniel Beck added a comment - May be related to a change in core that changed how build/buildWithParameter URLs are handled, if the plugin derives its promotion build type from the affected core base class. Tests using a selection of core versions (1.424.x, 1.447.x, 1.466.x, 1.480.x, 1.509.x, 1.532.x, 1.554.x, 1.565.x) would be helpful in determining whether this worked some time in the past.
            Hide
            stuartwhelan Stuart Whelan added a comment -

            We are getting this exact problem, a blank html page when trying to re-promote. On 1.580

            Show
            stuartwhelan Stuart Whelan added a comment - We are getting this exact problem, a blank html page when trying to re-promote. On 1.580

              People

              • Assignee:
                Unassigned
                Reporter:
                maxime_lem Maxime Lemanissier
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: