Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25312

GitHubCommitNotifier: Make the build result configurable on commit update failure

    Details

    • Similar Issues:

      Description

      Currently, GitHub notifier always fails the build if it cannot update the status. In several cases (conditional SCMs, etc.) it makes sense to set another statuses

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java
            src/main/resources/com/cloudbees/jenkins/GitHubCommitNotifier/config.jelly
            src/test/java/com/cloudbees/jenkins/GitHubCommitNotifierTest.java
            http://jenkins-ci.org/commit/github-plugin/f4ec7a602ce1cf714894aacebf5e0ddcf4750b1a
            Log:
            [FIXED JENKINS-25312] - Build status on update failure is configurable

            Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java src/main/resources/com/cloudbees/jenkins/GitHubCommitNotifier/config.jelly src/test/java/com/cloudbees/jenkins/GitHubCommitNotifierTest.java http://jenkins-ci.org/commit/github-plugin/f4ec7a602ce1cf714894aacebf5e0ddcf4750b1a Log: [FIXED JENKINS-25312] - Build status on update failure is configurable Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java
            src/main/resources/com/cloudbees/jenkins/GitHubCommitNotifier/config.jelly
            src/main/resources/com/cloudbees/jenkins/Messages.properties
            src/test/java/com/cloudbees/jenkins/GitHubCommitNotifierTest.java
            http://jenkins-ci.org/commit/github-plugin/b6f53a72bc27dd81cc1241c10c3e63d1606138de
            Log:
            Merge pull request #46 from oleg-nenashev/JENKINS-23641

            [JENKINS-23641,JENKINS-25312] - Handle possible nulls if Git checkout fails

            Compare: https://github.com/jenkinsci/github-plugin/compare/0f29b1d8d500...b6f53a72bc27

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java src/main/resources/com/cloudbees/jenkins/GitHubCommitNotifier/config.jelly src/main/resources/com/cloudbees/jenkins/Messages.properties src/test/java/com/cloudbees/jenkins/GitHubCommitNotifierTest.java http://jenkins-ci.org/commit/github-plugin/b6f53a72bc27dd81cc1241c10c3e63d1606138de Log: Merge pull request #46 from oleg-nenashev/ JENKINS-23641 [JENKINS-23641,JENKINS-25312] - Handle possible nulls if Git checkout fails Compare: https://github.com/jenkinsci/github-plugin/compare/0f29b1d8d500...b6f53a72bc27
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java
            http://jenkins-ci.org/commit/github-plugin/06b886a4eda250392eb272ee3c8a1dbb2de15fa3
            Log:
            JENKINS-25312 - Prevent NPE if build has not been finished yet

            May appear if somebody calls the publisher using AnyBuildStep

            Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java http://jenkins-ci.org/commit/github-plugin/06b886a4eda250392eb272ee3c8a1dbb2de15fa3 Log: JENKINS-25312 - Prevent NPE if build has not been finished yet May appear if somebody calls the publisher using AnyBuildStep Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: