Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2542

Points aren't added or subtracted for test cases

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: ci-game-plugin
    • Labels:
      None
    • Environment:
      Platform: Macintosh, OS: All
    • Similar Issues:

      Description

      Hi. I use Hudson to build Maven2 jobs. ci-game is a great plugin, but it seems
      it doesn't add/subtract points for new/removed test cases. If one or several
      tests fail (or are removed), the build is always worth exactly 0 points. If the
      build succeeds and one or more tests are added, the build is always worth
      exactly 1 point.

        Attachments

          Activity

          Hide
          redsolo redsolo added a comment -

          Thanks for the patch, looks good.. Dont know why i didnt do it the first time

          Show
          redsolo redsolo added a comment - Thanks for the patch, looks good.. Dont know why i didnt do it the first time
          Hide
          robdale robdale added a comment -

          When exactly should points be awarded? I'm not getting any for added tests.

          I have two maven 2 projects, both participate in CI Game.

          1. runs clean deploy (hourly for tests):
          Tests were added.. 0 failed..
          Total (diff)
          102 +102

          The scorecard shows:
          The build was successful 1.0

          Result: NO points for added tests!

          2. runs clean deploy site (nightly):
          Tests were added.. 0 failed..
          Total (diff)
          153 +153

          The scorecard shows:
          Rule Points
          3 checkstyle warnings were fixed 3.0
          The build was successful 1.0
          1 new LOW priority findbugs warnings were found -1.0
          2 new LOW priority PMD warnings were found -2.0
          1 new NORMAL priority findbugs warnings were found -3.0
          1 new NORMAL priority PMD warnings were found -3.0
          2 new open NORMAL priority tasks were found -6.0

          Result: NO points for added tests!

          I'm running Hudson 1.279 with ci-game (latest trunk) with patch applied.
          Manage plugins shows it running my CI Game build - 1.8-SNAPSHOT
          (private-03/11/2009 12:37-crdale)

          Show
          robdale robdale added a comment - When exactly should points be awarded? I'm not getting any for added tests. I have two maven 2 projects, both participate in CI Game. 1. runs clean deploy (hourly for tests): Tests were added.. 0 failed.. Total (diff) 102 +102 The scorecard shows: The build was successful 1.0 Result: NO points for added tests! 2. runs clean deploy site (nightly): Tests were added.. 0 failed.. Total (diff) 153 +153 The scorecard shows: Rule Points 3 checkstyle warnings were fixed 3.0 The build was successful 1.0 1 new LOW priority findbugs warnings were found -1.0 2 new LOW priority PMD warnings were found -2.0 1 new NORMAL priority findbugs warnings were found -3.0 1 new NORMAL priority PMD warnings were found -3.0 2 new open NORMAL priority tasks were found -6.0 Result: NO points for added tests! I'm running Hudson 1.279 with ci-game (latest trunk) with patch applied. Manage plugins shows it running my CI Game build - 1.8-SNAPSHOT (private-03/11/2009 12:37-crdale)
          Hide
          c9314310 c9314310 added a comment -

          Given that the diffs is the same as the totals, i would say that it was the first time you have run that
          project. To calculate the points it needs a previous test result to compare against. Try adding another test
          after you have run the project a least once and then you should get the points

          Show
          c9314310 c9314310 added a comment - Given that the diffs is the same as the totals, i would say that it was the first time you have run that project. To calculate the points it needs a previous test result to compare against. Try adding another test after you have run the project a least once and then you should get the points
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : redsolo
          Path:
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRule.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=17336
          Log:
          [FIXED JENKINS-2542] - Fixed so points are added or subtracted for test cases when run in a maven job

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRule.java http://fisheye4.cenqua.com/changelog/hudson/?cs=17336 Log: [FIXED JENKINS-2542] - Fixed so points are added or subtracted for test cases when run in a maven job
          Hide
          redsolo redsolo added a comment -

          Once again, thanks for the patch. Sorry that it has taken such a long time to fix it.
          Will release v 1.8 soon.

          Show
          redsolo redsolo added a comment - Once again, thanks for the patch. Sorry that it has taken such a long time to fix it. Will release v 1.8 soon.

            People

            • Assignee:
              redsolo redsolo
              Reporter:
              neu242 neu242
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: