Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25455

Code input field is too small

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core, groovy-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.586 on Windows
      Groovy-plugin 1.23
      Google Chrome 38.0.2125 /IE 9
    • Similar Issues:

      Description

      Not sure if this is a bug or desired behavior(see screenshot).
      When I add groovy script as a build step I can't add anything to it, because text field is too small. Of course I can easily make it bigger and write some code there, but in my opinion input field should not be so small by default.

        Attachments

          Activity

          Hide
          danielbeck Daniel Beck added a comment -

          Clearly a bug. Also, after resize, the gutter (where the line numbers are) is broken until something is typed.

          Show
          danielbeck Daniel Beck added a comment - Clearly a bug. Also, after resize, the gutter (where the line numbers are) is broken until something is typed.
          Hide
          vjuranek vjuranek added a comment -

          radiobox makes this element invisible and when CodeMirror computes height of the element it's zero (as element is not visible). Also gutter gets somehow broken during making it invisible and visible process. IMHO proper fix is PR #1460, however, to fix it soon (and for older Jenkins core version), I decided to pre-select StringScriptSource by default when adding new step and thus make it visible at the beginning.

          Show
          vjuranek vjuranek added a comment - radiobox makes this element invisible and when CodeMirror computes height of the element it's zero (as element is not visible). Also gutter gets somehow broken during making it invisible and visible process. IMHO proper fix is PR #1460 , however, to fix it soon (and for older Jenkins core version), I decided to pre-select StringScriptSource by default when adding new step and thus make it visible at the beginning.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          src/main/resources/hudson/plugins/groovy/Groovy/config.jelly
          src/main/resources/hudson/plugins/groovy/form/multi-hetero-radio.jelly
          http://jenkins-ci.org/commit/groovy-plugin/f91e2194790deb576acbe792dcec1c90a0071d2b
          Log:
          [FIXED JENKINS-25455] Show StringScriptSource by default and thus avoid zero height of the textarea

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: src/main/resources/hudson/plugins/groovy/Groovy/config.jelly src/main/resources/hudson/plugins/groovy/form/multi-hetero-radio.jelly http://jenkins-ci.org/commit/groovy-plugin/f91e2194790deb576acbe792dcec1c90a0071d2b Log: [FIXED JENKINS-25455] Show StringScriptSource by default and thus avoid zero height of the textarea
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          src/main/resources/hudson/plugins/groovy/SystemGroovy/config.jelly
          http://jenkins-ci.org/commit/groovy-plugin/dc6c57f9137f1b0e8590d1b90471d41b1ee7a559
          Log:
          JENKINS-25455 Use StringScriptSource as default also for System Groovy script

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: src/main/resources/hudson/plugins/groovy/SystemGroovy/config.jelly http://jenkins-ci.org/commit/groovy-plugin/dc6c57f9137f1b0e8590d1b90471d41b1ee7a559 Log: JENKINS-25455 Use StringScriptSource as default also for System Groovy script
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          core/src/main/resources/lib/form/textarea/textarea.js
          http://jenkins-ci.org/commit/jenkins/e9aeaf11b7171aed80381e8f66c5fb7056960141
          Log:
          JENKINS-25455 Avoid zero height of CodeMirror textarea

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: core/src/main/resources/lib/form/textarea/textarea.js http://jenkins-ci.org/commit/jenkins/e9aeaf11b7171aed80381e8f66c5fb7056960141 Log: JENKINS-25455 Avoid zero height of CodeMirror textarea
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3935
          JENKINS-25455 Avoid zero height of CodeMirror textarea (Revision e9aeaf11b7171aed80381e8f66c5fb7056960141)

          Result = UNSTABLE
          vojtech juranek : e9aeaf11b7171aed80381e8f66c5fb7056960141
          Files :

          • core/src/main/resources/lib/form/textarea/textarea.js
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3935 JENKINS-25455 Avoid zero height of CodeMirror textarea (Revision e9aeaf11b7171aed80381e8f66c5fb7056960141) Result = UNSTABLE vojtech juranek : e9aeaf11b7171aed80381e8f66c5fb7056960141 Files : core/src/main/resources/lib/form/textarea/textarea.js

            People

            • Assignee:
              vjuranek vjuranek
              Reporter:
              stargolem Dmitrijs Sahlovs
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: