Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25514

FutureImpl does not cancel it`s start future

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      FutureImpl does not cancel its attribute start, which is AsyncFutureImpl instance for identification that task is running.

      methos setAsCancelled() should cancel its attribute start too.

      It causes bug in method getStartCondition() in case cancellation of job in queue. Because start AssyncFuturaImpl is not set as cancelled and thread wich called getStartCondition() wait forever when job is cancelled in queue, because start is never cancelled.

      It can be seen in Build flow plugin.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Eugene Baranov
          Path:
          core/src/main/java/hudson/model/queue/FutureImpl.java
          test/src/test/java/hudson/model/QueueTest.java
          http://jenkins-ci.org/commit/jenkins/3edae667b3955a561296a23122f86b35ec928a98
          Log:
          JENKINS-25514 Fixed lock case in FutureImpl
          when some other process is waiting for build in queue.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Eugene Baranov Path: core/src/main/java/hudson/model/queue/FutureImpl.java test/src/test/java/hudson/model/QueueTest.java http://jenkins-ci.org/commit/jenkins/3edae667b3955a561296a23122f86b35ec928a98 Log: JENKINS-25514 Fixed lock case in FutureImpl when some other process is waiting for build in queue.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/model/queue/FutureImpl.java
          test/src/test/java/hudson/model/QueueTest.java
          http://jenkins-ci.org/commit/jenkins/5bfaca449ce3b6edbf39a3f623bc8ce62411b37e
          Log:
          Merge pull request #1472 from jbaranov/JENKINS-25514

          JENKINS-25514 Fixed lock case in FutureImpl

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/queue/FutureImpl.java test/src/test/java/hudson/model/QueueTest.java http://jenkins-ci.org/commit/jenkins/5bfaca449ce3b6edbf39a3f623bc8ce62411b37e Log: Merge pull request #1472 from jbaranov/ JENKINS-25514 JENKINS-25514 Fixed lock case in FutureImpl
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3915

          Result = SUCCESS

          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3915 Result = SUCCESS
          Hide
          danielbeck Daniel Beck added a comment -

          Is this LTS-worthy?

          Show
          danielbeck Daniel Beck added a comment - Is this LTS-worthy?

            People

            • Assignee:
              lvotypkova Lucie Votypkova
              Reporter:
              lvotypkova Lucie Votypkova
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: