Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25678

BatchController subject to space-in-path bug

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      call c:\windows\temp\slave\workspace\windoze with git\.c47b7018\jenkins-main.bat > c:\windows\temp\slave\workspace\windoze with git\.c47b7018\jenkins-log.txt 2>&1
      echo %ERRORLEVEL% > c:\windows\temp\slave\workspace\windoze with git\.c47b7018\jenkins-result.txt
      

      will not work.

      Renaming the job to not have spaces in its name makes it work.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            durable-task-step/src/main/java/org/jenkinsci/plugins/workflow/steps/durable_task/DurableTaskStep.java
            http://jenkins-ci.org/commit/workflow-plugin/9901d51bee1eae473ba9f57810643b8e8e4cfe79
            Log:
            If the user asks to stop a shell step twice, force it to die.
            Works around bugs like JENKINS-25678 which would otherwise make the flow unkillable.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: durable-task-step/src/main/java/org/jenkinsci/plugins/workflow/steps/durable_task/DurableTaskStep.java http://jenkins-ci.org/commit/workflow-plugin/9901d51bee1eae473ba9f57810643b8e8e4cfe79 Log: If the user asks to stop a shell step twice, force it to die. Works around bugs like JENKINS-25678 which would otherwise make the flow unkillable.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java
            http://jenkins-ci.org/commit/durable-task-plugin/1a937ee6ca37e547865adfafadfb0a27a2216d77
            Log:
            [FIXED JENKINS-25678] Quote arguments in case we are running in a directory whose name contains spaces.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java http://jenkins-ci.org/commit/durable-task-plugin/1a937ee6ca37e547865adfafadfb0a27a2216d77 Log: [FIXED JENKINS-25678] Quote arguments in case we are running in a directory whose name contains spaces.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java
            src/test/java/org/jenkinsci/plugins/durabletask/WindowsBatchScriptTest.java
            http://jenkins-ci.org/commit/durable-task-plugin/89be896b84a70ec34fe83b90c53cfee989256bf0
            Log:
            Merge pull request #4 from jglick/JENKINS-25678-space-in-path

            JENKINS-25678 Space-in-path bug

            Compare: https://github.com/jenkinsci/durable-task-plugin/compare/bf5101c9a55d...89be896b84a7

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java src/test/java/org/jenkinsci/plugins/durabletask/WindowsBatchScriptTest.java http://jenkins-ci.org/commit/durable-task-plugin/89be896b84a70ec34fe83b90c53cfee989256bf0 Log: Merge pull request #4 from jglick/ JENKINS-25678 -space-in-path JENKINS-25678 Space-in-path bug Compare: https://github.com/jenkinsci/durable-task-plugin/compare/bf5101c9a55d...89be896b84a7
            Hide
            jglick Jesse Glick added a comment -

            Fix does not seem to work for concurrent workspaces like some project@2.

            Show
            jglick Jesse Glick added a comment - Fix does not seem to work for concurrent workspaces like some project@2 .
            Hide
            jglick Jesse Glick added a comment -

            According to the source,

            If you specify /c or /k, cmd processes the remainder of string and quotation marks are preserved only if all of the following conditions are met: … You do not use any special characters within the quotation marks (for example: &<>( ) @ ^ |).

            Show
            jglick Jesse Glick added a comment - According to the source , If you specify /c or /k , cmd processes the remainder of string and quotation marks are preserved only if all of the following conditions are met: … You do not use any special characters within the quotation marks (for example: &<>( ) @ ^ |).
            Hide
            jglick Jesse Glick added a comment -

            Seems you need to use two sets of ".

            Show
            jglick Jesse Glick added a comment - Seems you need to use two sets of " .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java
            src/test/java/org/jenkinsci/plugins/durabletask/WindowsBatchScriptTest.java
            http://jenkins-ci.org/commit/durable-task-plugin/38fc4709fb89da12b78e79d1292298de3d5ca24e
            Log:
            [FIXED JENKINS-25678] Double-double quoting to handle paths with both spaces and special characters like @.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java src/test/java/org/jenkinsci/plugins/durabletask/WindowsBatchScriptTest.java http://jenkins-ci.org/commit/durable-task-plugin/38fc4709fb89da12b78e79d1292298de3d5ca24e Log: [FIXED JENKINS-25678] Double-double quoting to handle paths with both spaces and special characters like @.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java
            src/test/java/org/jenkinsci/plugins/durabletask/WindowsBatchScriptTest.java
            http://jenkins-ci.org/commit/durable-task-plugin/92014f174b6064a9368a8cee60bc74e5ae7d9821
            Log:
            Merge pull request #18 from jglick/win-space-in-path-JENKINS-25678

            JENKINS-25678 Space-in-path bug, revisited

            Compare: https://github.com/jenkinsci/durable-task-plugin/compare/fa1959dec398...92014f174b60

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java src/test/java/org/jenkinsci/plugins/durabletask/WindowsBatchScriptTest.java http://jenkins-ci.org/commit/durable-task-plugin/92014f174b6064a9368a8cee60bc74e5ae7d9821 Log: Merge pull request #18 from jglick/win-space-in-path- JENKINS-25678 JENKINS-25678 Space-in-path bug, revisited Compare: https://github.com/jenkinsci/durable-task-plugin/compare/fa1959dec398...92014f174b60

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: