Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25785

Windows slaves controlled as Windows Service do not use credentials manager

    Details

    • Type: Improvement
    • Status: In Progress (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: windows-slaves-plugin
    • Labels:
      None
    • Environment:
      jenkins 1.576, windows-slaves-plugin 1.0
    • Similar Issues:

      Description

      When connecting Unix machines through SSH,the SSH Slaves plugin uses the SSH Credentials plugin to be able to store the SSH credentials in one place. Then when or if these credentials change, they only have to be updated in one place to update every affected SSH slave connected.

      However, when adding a Windows slave, using the "Let Jenkins Control this Windows Slave as Windows service" method, each slave connected has its own authentication credentials. This means after a password change that every Windows slave configuration must be updated. These credentials for Windows slaves should be stored in the Credentials Manager plugin, and used from there, then the storing of credentials for Windows or Unix slaves would be consistent, and the maintenance of Windows slaves would be reduced.

        Attachments

          Issue Links

            Activity

            Show
            vlatombe Vincent Latombe added a comment - - edited Submitted https://github.com/jenkinsci/windows-slaves-plugin/pull/3/
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Vincent Latombe
            Path:
            core/src/main/java/hudson/ClassicPluginStrategy.java
            http://jenkins-ci.org/commit/jenkins/a65d007533cc882d85715677ec75f06e001e1e8a
            Log:
            Prerequisite for JENKINS-25785 in order to break dependency cycle when windows-slaves will depend on credentials

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vincent Latombe Path: core/src/main/java/hudson/ClassicPluginStrategy.java http://jenkins-ci.org/commit/jenkins/a65d007533cc882d85715677ec75f06e001e1e8a Log: Prerequisite for JENKINS-25785 in order to break dependency cycle when windows-slaves will depend on credentials
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/ClassicPluginStrategy.java
            http://jenkins-ci.org/commit/jenkins/78f631805dacc6682e67123bd5e9c16e251259ef
            Log:
            Merge pull request #1735 from Vlatombe/JENKINS-25785_prerequisite

            Prerequisite for JENKINS-25785

            Compare: https://github.com/jenkinsci/jenkins/compare/f3f8abd36bdd...78f631805dac

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/ClassicPluginStrategy.java http://jenkins-ci.org/commit/jenkins/78f631805dacc6682e67123bd5e9c16e251259ef Log: Merge pull request #1735 from Vlatombe/ JENKINS-25785 _prerequisite Prerequisite for JENKINS-25785 Compare: https://github.com/jenkinsci/jenkins/compare/f3f8abd36bdd...78f631805dac
            Hide
            deag Diogo Guerra added a comment -

            Vincent Latombe I'm having some problems on using the credentials plugin with jgit and windows slave. It seems that the credentials are never used (not a problem of changes and restarts). I don't know in depth the source but is your patch integrating the credentials plugin with the windows slaves plugin?

            I'm using Jenkins 2.2, git plugin 2.4.4, windows slaves 1.1. It works well with linux slaves but windows ones it doesn't.

            Show
            deag Diogo Guerra added a comment - Vincent Latombe I'm having some problems on using the credentials plugin with jgit and windows slave. It seems that the credentials are never used (not a problem of changes and restarts). I don't know in depth the source but is your patch integrating the credentials plugin with the windows slaves plugin? I'm using Jenkins 2.2, git plugin 2.4.4, windows slaves 1.1. It works well with linux slaves but windows ones it doesn't.
            Hide
            vlatombe Vincent Latombe added a comment -

            Diogo Guerra My patch allows to use credentials to start a windows slave instead of plain user/pwd from the UI. If you have a problem related to jgit/windows slaves, it probably has nothing to do with this.

            Show
            vlatombe Vincent Latombe added a comment - Diogo Guerra My patch allows to use credentials to start a windows slave instead of plain user/pwd from the UI. If you have a problem related to jgit/windows slaves, it probably has nothing to do with this.

              People

              • Assignee:
                vlatombe Vincent Latombe
                Reporter:
                rickybobpat Rick Patterson
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: