Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25800

parseLog() in NaginatorListener.java does not close its BufferedReader or FileReader, leaking OS resources

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Hello!

      I was taking a look at how regex was handled in this plugin, and ran across this:

      https://github.com/jenkinsci/naginator-plugin/blob/master/src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java#L144-L161

      It looks like the plugin never actually calls close on either reader. This will leak file handles and potentially system/OS buffers for each build log (and build logs can get huge).

      This method should close the outside wrapper / buffered reader.

        Attachments

          Activity

          martinb3 Martin Smith created issue -
          scm_issue_link SCM/JIRA link daemon made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 159780 ] JNJira + In-Review [ 196195 ]

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              martinb3 Martin Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: