Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2592

The one who fixes the build gets punished

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: ci-game-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      I love the CI Game. However, when a build is broken all checkstyle, pmd and
      other checks are not collected. Then when the build is fixed, the fixer gets the
      points. Just to make an example.
      User 1 does a big commit, the build is broken and many checkstyle defects are
      introduced. Build stays broken and User 1 goes on course.
      User 2 fixes the build and gets the -80 points from all the checkstyle warnings!
      Ouch.
      Maybe you can assign all minus points to the build breaker, and give the build
      fixer the positive points.

        Attachments

          Activity

          Hide
          uncletall uncletall added a comment -

          Sounds like a reasonable solution to me

          Show
          uncletall uncletall added a comment - Sounds like a reasonable solution to me
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : redsolo
          Path:
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/checkstyle/DefaultCheckstyleRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/findbugs/FixedFindBugsWarningsRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/findbugs/NewFindBugsWarningsRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/opentasks/DefaultOpenTasksRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/pmd/DefaultPmdRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/violation/DefaultViolationRule.java
          trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/warnings/DefaultWarningsRule.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=20477
          Log:
          JENKINS-2592 - Fixed so the rules will only give out points if current and previous build did not fail (or worse).

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : redsolo Path: trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/checkstyle/DefaultCheckstyleRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/findbugs/FixedFindBugsWarningsRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/findbugs/NewFindBugsWarningsRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/opentasks/DefaultOpenTasksRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/pmd/DefaultPmdRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/violation/DefaultViolationRule.java trunk/hudson/plugins/ci-game/src/main/java/hudson/plugins/cigame/rules/plugins/warnings/DefaultWarningsRule.java http://fisheye4.cenqua.com/changelog/hudson/?cs=20477 Log: JENKINS-2592 - Fixed so the rules will only give out points if current and previous build did not fail (or worse).
          Hide
          redsolo redsolo added a comment -

          If you woulike to try this fix out, you can find a snapshot version at http://hudson.ramfelt.se/job/Hudson%20plugin%20The%20Continuous%20Integration%20Ga
          me/117/

          Show
          redsolo redsolo added a comment - If you woulike to try this fix out, you can find a snapshot version at http://hudson.ramfelt.se/job/Hudson%20plugin%20The%20Continuous%20Integration%20Ga me/117/
          Hide
          kutzi kutzi added a comment -

          CC'ed myself

          Show
          kutzi kutzi added a comment - CC'ed myself
          Hide
          redsolo redsolo added a comment -

          It wouldb be nice if anyone could verify the fix before i release the plugin.
          Snapshot is available at http://hudson.ramfelt.se/job/Hudson%20plugin%20The%20Continuous%20Integration%20Ga
          me/

          Show
          redsolo redsolo added a comment - It wouldb be nice if anyone could verify the fix before i release the plugin. Snapshot is available at http://hudson.ramfelt.se/job/Hudson%20plugin%20The%20Continuous%20Integration%20Ga me/

            People

            • Assignee:
              redsolo redsolo
              Reporter:
              uncletall uncletall
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: