Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25953

Layout - Tabs in job view are layouted in wrong way

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Environment:
      Jenkins ver. 1.580.1. Mac. Chrome browser
    • Similar Issues:

      Description

      Take a look at screen shots, when I select tab "test4" there is extra padding in whole next line, "test7" begin just after "test4" in second line.
      When "test6" is selected it looks fine.

        Attachments

          Issue Links

            Activity

            pwielgolaski Piotr Wielgołaski created issue -
            Hide
            pwielgolaski Piotr Wielgołaski added a comment -

            it seems that one of solution to fix it is to add:
            "padding-bottom: 6px;" into
            https://github.com/jenkinsci/jenkins/blob/master/war/src/main/webapp/css/style.css#L412
            In this way all tabs have the same height.

            Show
            pwielgolaski Piotr Wielgołaski added a comment - it seems that one of solution to fix it is to add: "padding-bottom: 6px;" into https://github.com/jenkinsci/jenkins/blob/master/war/src/main/webapp/css/style.css#L412 In this way all tabs have the same height.
            Hide
            pwielgolaski Piotr Wielgołaski added a comment -

            Screenshot with fix attached

            Show
            pwielgolaski Piotr Wielgołaski added a comment - Screenshot with fix attached
            pwielgolaski Piotr Wielgołaski made changes -
            Field Original Value New Value
            Attachment Screen Shot 2014-12-07 at 13.55.50.png [ 28136 ]
            Hide
            pwielgolaski Piotr Wielgołaski added a comment -
            Show
            pwielgolaski Piotr Wielgołaski added a comment - Fix in pull request https://github.com/jenkinsci/jenkins/pull/1483
            xter Benjamin Dewez made changes -
            Link This issue is related to JENKINS-26015 [ JENKINS-26015 ]
            iambaskar Baskaran D made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            iambaskar Baskaran D added a comment -

            @PiotrWielgolaski - Tested your fix and it didnt work for me. I have updated the code @ https://github.com/jenkinsci/jenkins/pull/1544. Please take a look at it.

            Show
            iambaskar Baskaran D added a comment - @PiotrWielgolaski - Tested your fix and it didnt work for me. I have updated the code @ https://github.com/jenkinsci/jenkins/pull/1544 . Please take a look at it.
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-26661 [ JENKINS-26661 ]
            Hide
            danilo_saita Danilo Saita added a comment - - edited

            I have the same problem on 1.596 - Chrome Version 39.0.2171.71 (64-bit)

            Is the issue really in progress?

            Show
            danilo_saita Danilo Saita added a comment - - edited I have the same problem on 1.596 - Chrome Version 39.0.2171.71 (64-bit) Is the issue really in progress?
            Hide
            iambaskar Baskaran D added a comment -

            The fix is under code review. Its yet to be merged.

            Show
            iambaskar Baskaran D added a comment - The fix is under code review. Its yet to be merged.
            danielbeck Daniel Beck made changes -
            Labels layout layout lts-candidate
            Hide
            iambaskar Baskaran D added a comment -

            Closed https://github.com/jenkinsci/jenkins/pull/1544.

            @PiotrWielgolaski's Pull request should work fine. - https://github.com/jenkinsci/jenkins/pull/1483

            Show
            iambaskar Baskaran D added a comment - Closed https://github.com/jenkinsci/jenkins/pull/1544 . @PiotrWielgolaski's Pull request should work fine. - https://github.com/jenkinsci/jenkins/pull/1483
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Piotr Wielgolaski
            Path:
            war/src/main/webapp/css/style.css
            http://jenkins-ci.org/commit/jenkins/70613202f1177ce83e1d9d724a8b21ca9c222cd3
            Log:
            JENKINS-25953Tabs in job view are layouted in wrong way

            make equal height of tab regardless if selected or not

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Piotr Wielgolaski Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/70613202f1177ce83e1d9d724a8b21ca9c222cd3 Log: JENKINS-25953 Tabs in job view are layouted in wrong way make equal height of tab regardless if selected or not
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            war/src/main/webapp/css/style.css
            http://jenkins-ci.org/commit/jenkins/27dbc6bc588b2a6b44fda7238207994c197a5e2d
            Log:
            Merge pull request #1483 from pwielgolaski/JENKINS-25953

            [FIXED JENKINS-25953]Tabs in job view are layouted in wrong way

            Compare: https://github.com/jenkinsci/jenkins/compare/17baaf7151fb...27dbc6bc588b

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/27dbc6bc588b2a6b44fda7238207994c197a5e2d Log: Merge pull request #1483 from pwielgolaski/ JENKINS-25953 [FIXED JENKINS-25953] Tabs in job view are layouted in wrong way Compare: https://github.com/jenkinsci/jenkins/compare/17baaf7151fb...27dbc6bc588b
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3971
            JENKINS-25953Tabs in job view are layouted in wrong way (Revision 70613202f1177ce83e1d9d724a8b21ca9c222cd3)

            Result = SUCCESS
            pwielgolaski : 70613202f1177ce83e1d9d724a8b21ca9c222cd3
            Files :

            • war/src/main/webapp/css/style.css
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3971 JENKINS-25953 Tabs in job view are layouted in wrong way (Revision 70613202f1177ce83e1d9d724a8b21ca9c222cd3) Result = SUCCESS pwielgolaski : 70613202f1177ce83e1d9d724a8b21ca9c222cd3 Files : war/src/main/webapp/css/style.css
            olivergondza Oliver Gondža made changes -
            Labels layout lts-candidate 1.596.2-fixed layout
            olivergondza Oliver Gondža made changes -
            Labels 1.596.2-fixed layout 1.596.3-fixed layout
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Piotr Wielgolaski
            Path:
            war/src/main/webapp/css/style.css
            http://jenkins-ci.org/commit/jenkins/f624aab02251fa7d4d97b05d41954d5dc34575a0
            Log:
            JENKINS-25953Tabs in job view are layouted in wrong way

            make equal height of tab regardless if selected or not

            (cherry picked from commit 70613202f1177ce83e1d9d724a8b21ca9c222cd3)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Piotr Wielgolaski Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/f624aab02251fa7d4d97b05d41954d5dc34575a0 Log: JENKINS-25953 Tabs in job view are layouted in wrong way make equal height of tab regardless if selected or not (cherry picked from commit 70613202f1177ce83e1d9d724a8b21ca9c222cd3)
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4292
            JENKINS-25953Tabs in job view are layouted in wrong way (Revision f624aab02251fa7d4d97b05d41954d5dc34575a0)

            Result = UNSTABLE
            ogondza : f624aab02251fa7d4d97b05d41954d5dc34575a0
            Files :

            • war/src/main/webapp/css/style.css
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 JENKINS-25953 Tabs in job view are layouted in wrong way (Revision f624aab02251fa7d4d97b05d41954d5dc34575a0) Result = UNSTABLE ogondza : f624aab02251fa7d4d97b05d41954d5dc34575a0 Files : war/src/main/webapp/css/style.css
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 159941 ] JNJira + In-Review [ 196253 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                pwielgolaski Piotr Wielgołaski
              • Votes:
                3 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: