Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26051

Workflow integration for Credentials Binding

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      A replacement for SecretBuildWrapper that is a Step (with invokeBodyLater) rather than a BuildWrapper, probably returning the binding(s) in a map.

      Means some API changes to Binding. bind must take a FilePath workspace (and maybe Run run) rather than AbstractBuild build. And Environment must be declared Serializable, since unbind may be called in another session.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
            http://jenkins-ci.org/commit/workflow-support-plugin/18ad074331b663f565633bf4fa8523ac68dc1a69
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-support-plugin/18ad074331b663f565633bf4fa8523ac68dc1a69 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/85812e78a3ab6c837b59002082e30bdc16294688
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/85812e78a3ab6c837b59002082e30bdc16294688 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-scm-step-plugin/7583bf18eda2968bebc10024b52aee00a3614149
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/7583bf18eda2968bebc10024b52aee00a3614149 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/89c28b4fca0eb81cf369ff699f7a4d801fc83e83
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/89c28b4fca0eb81cf369ff699f7a4d801fc83e83 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/fe863c4a5ba855d65cd68588a71e5293f0bdf641
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/fe863c4a5ba855d65cd68588a71e5293f0bdf641 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: